Add support for Graphics Device Interface Acceleration Extensions (MS-RDPEGDI) #187
Conversation
alxbl
force-pushed
the
gdi-support
branch
3 times, most recently
from
a9e1b67
to
7523aa4
Compare
|
The branch is now in a state where I feel comfortable getting a thorough code review. I'm in the process of doing more exhaustive tests using Windows 7 and Windows Server 2012. |
alxbl
changed the title
There was a problem hiding this comment.
I looked quickly-ish, let some comment but I'll let @obilodeau approve!
|
Rebased this on master since there have been a lot of changes. |
|
@alxbl: new conflicts. sorry 😞 |
|
Conflicts are resolved. I want this to land before mp4 conversion if possible. |
There was a problem hiding this comment.
This is very impressive work! It is hard to do a review that does it justice...
One thing that isn't clear to me: are we now coupling with Qt so much that this code won't work unless we have PySide2 / QT installed? I'm thinking about our docker-slim and potentially rasp pi MITM deployments.
Copyright years should be updated in all touched files, I did suggestions for many of them but I think I missed a few ones (including the files that aren't new since it was not in diff context). A git log --stat on this branch should help identify all files to verify.
🚀 👏 🍯
|
All the things have been flakified. |
This pull request adds support for the MS-RDPEGDI extension and drawing orders.
I'm opening it now despite being only roughly halfway done with the changes in order to give some visibility as to the overall changes so far.
What's done
What's left to do
[ ] Implement NINEGRID support and rendering (currently downgrading)Closes #50
Fixes #162