Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #200

Closed
10 of 14 tasks
Res260 opened this issue Mar 25, 2020 · 4 comments
Closed
10 of 14 tasks

CI improvements #200

Res260 opened this issue Mar 25, 2020 · 4 comments
Labels
enhancement New feature or request idea
Projects
Milestone

Comments

@Res260
Copy link
Collaborator

Res260 commented Mar 25, 2020

Here are some ideas to test some parts that are not tested yet in the current CI or generally improve the CI/CD pipeline:

Add a different github workflow to push a docker image on the PyRDP Docker Registry to have PyRDP-latest, synced with Master (see comments)

@Res260 Res260 added enhancement New feature or request idea labels Mar 25, 2020
@obilodeau
Copy link
Member

Add a different github workflow to push a docker image on the PyRDP Docker Registry to have PyRDP-latest, synced with Master

This is already done from DockerHub. latest and integration image tags are automatically updated from GitHub branches master and integration. Notifications for success/failure integrated into our work slack. Tagged releases are automatically converted into a tag image too. Ie: gosecure/pyrdp:0.4.1.

Although we could build via GitHub Actions, the complicated setup required (OAuth tokens, machine accounts, configuration, etc.) has already been done so it would need to offer a substantial benefit to switching over to it.

@Res260
Copy link
Collaborator Author

Res260 commented Mar 25, 2020

Makes sense I thought it was a manual process!

@Res260
Copy link
Collaborator Author

Res260 commented Apr 18, 2020

Added

  • Test with many python versions (can be done using the matrix settings of github workflows)

@alxbl alxbl added this to Backlog in Ideas Aug 6, 2020
@alxbl alxbl moved this from Backlog to WIP in Ideas Aug 6, 2020
@obilodeau
Copy link
Member

Lately I added a test with a replay (not a pcap) with GDI content in it. I ticked the appropriate boxes from this issue's task list.

@obilodeau obilodeau added this to the v1.3.0 milestone Dec 5, 2023
Ideas automation moved this from WIP to Implemented Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idea
Projects
Ideas
  
Implemented
Development

No branches or pull requests

2 participants