feat: Add support for logging configuration files. #191
Conversation
alxbl
force-pushed
the
logging-configuration
branch
from
f8f7075
to
e188747
Compare
|
There is a conflict to resolve before this can be merged too. |
|
Hmm, the conflict is fairly involved because of the headless work and the fact that loggers got mass-renamed in the player. I would advise that the conflict resolution should be visible in the PR and not done during the merge. I think either a rebase or a merge from master in the branch will achieve that. |
|
Merge commit into integration with manual conflict resolution: 76b5b7a |
|
Integration passed CI: https://github.com/GoSecure/pyrdp/runs/534227539?check_suite_focus=true |
alxbl
force-pushed
the
logging-configuration
branch
from
c352799
to
16b4696
Compare
|
I rebased on master, resolved conflicts and added deduplicated the configuration files. I'm going to fix the twistd CLI issue once and for all, as part of this, too. I don't want to document the logging configurations yet, as I'd like to expose other configuration settings in the .ini file before making it an official feature. |
alxbl
force-pushed
the
logging-configuration
branch
from
3b78221
to
afbcfa3
Compare
|
I'm sorry to say it but this needs a mention in the README. The files are very self-documented so no need to copy content over but there should be a pointer to the existence of the ini files and where to grab them. Since our install workflow involves git this will be very simple. For malboxes, installed via pip+git, this is platform-dependent and complicated... |
|
Done. I guess I'll expose the rest of the configuration sooner rather than later. |
|
Time to rebase my friend! 🚀 |
This exposes all logging configuration (and eventually command line flags) through a configuration file.
The idea is to give users more control on what is output and eventually simplify launching the tool.
The PR is a draft because I want to clean up the existing logging code and add support for the player before merging.
The plan is to have a
mitm.iniandplayer.iniwhich contains all configuration parameters for PyRDP. We could also theoretically have a singleconfig.iniwhich all tools read, but that would increase log configuration complexity.