Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Buffer replays until connection is established. Fixes #169 #207

Merged
merged 2 commits into from
Apr 15, 2020
Merged

fix: Buffer replays until connection is established. Fixes #169 #207

merged 2 commits into from
Apr 15, 2020

Conversation

alxbl
Copy link
Collaborator

@alxbl alxbl commented Apr 8, 2020 •
edited

Fixes #169

Res260
Res260 approved these changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@Res260 Res260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

pyrdp/recording/recorder.py Outdated Show resolved Hide resolved
@obilodeau
Copy link
Member

Good

@obilodeau obilodeau merged commit 65e798a into master Apr 15, 2020
@obilodeau obilodeau deleted the fix-169 branch August 6, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Res260 Res260 Res260 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0/18 byte files in replay folder
3 participants
@alxbl @obilodeau @Res260