Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve static typing and style #69

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Jan 20, 2023

Lots of little things to make it easier to avoid issues in the future.
Please test this with your mods, it should not have any effect at all.
Let me know if I missed something

@Qubus0 Qubus0 requested review from ithinkandicode and a team January 20, 2023 20:40
@Qubus0 Qubus0 changed the base branch from main to develop January 20, 2023 23:48
@KANAjetzt
Copy link
Collaborator

KANAjetzt commented Jan 22, 2023

I think #70 is missing on this one - right?

*edit:
Ah eh yes we are in #69 😅

@Qubus0
Copy link
Collaborator Author

Qubus0 commented Jan 22, 2023

@KANAjetzt develop is missing #70 as well, since it got merged past

I just had another look, the log ignoring from #70 is all here, nothing missing.

Copy link
Collaborator

@ithinkandicode ithinkandicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Qubus0 Qubus0 merged commit 2ef464b into GodotModding:develop Jan 23, 2023
@Qubus0 Qubus0 deleted the improve_static_typing_and_style branch January 23, 2023 22:12
@KANAjetzt KANAjetzt mentioned this pull request Feb 15, 2023
@KANAjetzt KANAjetzt mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants