-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.2.0 #112
Conversation
fix mods dir path not being overridden
Self setup
Improve static typing and style
fix type inference of game_mod_folder_path
Add overwrite functionality
…elog `log_fatal` - add the missing log to file
…m/KANAjetzt/godot-mod-loader into setup_create_override_cfg_cli_arg
--setup-create-override-cfg cli arg
Utils for ModLoader autoload position
* fix: properly parse all types of command line arg values * refactor: adjust code line in doc comments * refactor: add cmdline arg fixing wrapper function * fix: also cover args without =
because the notice is most likely to be seen by modders in the editor, who won't be using the `mods` dir
* `get_mod_config` - fix missing space in log string * `get_mod_config` - log improvements - Generally improve log messages, giving them better user notices that are more accurate to the current issue. - Use assert for cases where there are definite code errors that need addressing (eg. an invalid mod ID) * `get_mod_config` - use enums for the error codes * `get_mod_config` - rename "error" (eg. "error code") to "status" * `get_mod_config` - remove a redundant bit of text
* ✔ added checks for override.cfg setup * 🧹 removed logging when no autoloads are set up If there is no autoloads there will be no mod_loader.gd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we're good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't have much to say, I think this version is ready for merge as it's the one I have been using till now for development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
edit by @ithinkandicode:
Includes PR #69, and all merged PRs from #70 up to PR #110
modloaderutils
#84 by @ithinkandicode_handle_missing_dependency
#90 by @ithinkandicodelog_fatal
- add the missing log to file #102 by @ithinkandicodemods
dir error to a warning #107 by @ithinkandicodeOriginal description by @KANAjetzt:
static types
Improve static typing and style #69
improved version validation
upgrade semver validation to disallow leading zeros and overly long versions #71
improved dependency validation
Validate dependencies and incompatibilities #91
mod_loader_setup.gd -> setup script with override.cfg or project.binary injection
Self setup #75
remove run.gd, as it's no longer needed #78
Project binary injection #89
--only-setup cli arg #94
Assert modloader is first autoload #96
--setup-create-override-cfg cli arg #99
Utils for ModLoader autoload position #104
Check modloader autoload position on setup #105
✔ added checks for override.cfg setup #110
overwrite handling with a new overwrites.gd file
Add overwrite functionality #74
Log file rotation ( delete old log files )
store log backups and rotate them like godot #100