New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overwrite functionality #74
Add overwrite functionality #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some very minor things, borderline nitpicks 😁
@@ -222,6 +222,13 @@ static func get_json_string_as_dict(string: String) -> Dictionary: | |||
return {} | |||
return parsed.result | |||
|
|||
static func is_file_existing(path: String) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these funcs be renamed into something more semantic, ie. to be more human readable? The phrase "is file existing" isn't quite grammatically correct. Eg. would does_file_exist
be ok for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just use the build in function name?
file_exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good man! Looks like I'll need to re-approve once the merge conflicts are fixed but I'll approve here anyway 😁
Let mod authors create the
overwrites.gd
at the root of the mod folderoverwrites.gd
script andoverwrites
folder in there mod folder:overwrites.gd
script a one click thingoverwrites.gd
them selfoverwrites.gd
from example mod:Example Mod with this setup:
KANA-OverwritesTest.zip
Testing Godot Project
( does not include the Mod Loader - pls use this PR to test )
ModdingTest.zip
closes #14