Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert modloader is first autoload #96

Merged
merged 2 commits into from
Feb 5, 2023
Merged

Assert modloader is first autoload #96

merged 2 commits into from
Feb 5, 2023

Conversation

ithinkandicode
Copy link
Collaborator

Asserts that ModLoader is the first autoload.

The error messages aim to be as helpful as possible, and change depending on if you're in the editor or not.

Also logs the autoloads, via code by @KANAjetzt (originally from his PR #81).

Closes #87

@ithinkandicode ithinkandicode changed the base branch from main to develop February 5, 2023 03:03
@ithinkandicode ithinkandicode added the validation Feature to make things safe and predictable label Feb 5, 2023
Qubus0
Qubus0 approved these changes Feb 5, 2023
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a little naming consistency thing - is_mod_loader_first(_autoload) but either way is fine

@ithinkandicode
Copy link
Collaborator Author

Only a little naming consistency thing - is_mod_loader_first(_autoload) but either way is fine

@Qubus0 ty, fixed

@ithinkandicode ithinkandicode merged commit e066e4e into GodotModding:develop Feb 5, 2023
@ithinkandicode ithinkandicode mentioned this pull request Feb 5, 2023
Closed
@KANAjetzt KANAjetzt mentioned this pull request Feb 7, 2023
Merged
@ithinkandicode ithinkandicode changed the title Assert modlaoder is first autoload Assert modloader is first autoload Feb 8, 2023
This was referenced Feb 8, 2023
Merged
Merged
@KANAjetzt KANAjetzt mentioned this pull request Feb 23, 2023
Merged
@ithinkandicode ithinkandicode mentioned this pull request Feb 24, 2023
Closed
@ithinkandicode ithinkandicode deleted the assert-modlaoder-is-first-autoload branch February 28, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

@KANAjetzt KANAjetzt Awaiting requested review from KANAjetzt

Assignees
No one assigned
Labels
validation Feature to make things safe and predictable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert that ML is first autoload
2 participants
@ithinkandicode @Qubus0