Enhancements to footstep audio system #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malcolmnixon
force-pushed
the
footstep-resource-leak
branch
from
aa6fad3
to
4ae1e69
Compare
|
lgtm |
It's not always possible but I think we should do this in more situations. It really cleans up the UI |
|
Don't forget to change the |
…o resources to be optional. Fixed resource leak by not attempting to play null sounds. Added signal emitted when a surface sound is played (possibly to alert enemies) Made walk speed configurable. Moved audio settings to an AudioStreamPlayer3D child node. Modified when footsteps are played to be at the "end" of a step. Modified all footstep sounds to be wave files to avoid delay when playing the sounds. Minor formatting cleanup Updated VERSIONS.md to describe change.
Malcolmnixon
force-pushed
the
footstep-resource-leak
branch
from
4ae1e69
to
6bec464
Compare
|
Updated VERSIONS.md, and I'll work on the documentation page shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #373 by avoiding attempting to play null sounds; however this PR also includes numerous other changes.
Surface audio resources now have a jump sound, and all sounds (jump, hit, and walk) are optional and can be left blank.
The walk speed is now a configurable property. The footsteps node now emits a footstep signal whenever it plays a footstep sound, and the audio settings have been moved to a child AudioStreamPlayer3D node called "PlayerSettings" so the footstep node doesn't have to try and replicate every audio setting (bus, mix, attenuation, etc.)
All reference footstep sounds have been converted to WAV files as OGG files have a fairly large delay when playing due to the effort of decompressing the audio stream.
Finally the math behind when the footstep sounds are played has been shifted so it plays at the "end" of a step rather than at the beginning.