Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVR actions.json file is loaded from one of 3 fixed locations #105

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

BastiaanOlij
Copy link
Member

@BastiaanOlij BastiaanOlij commented Aug 22, 2020

The plugin will now look for the actions.json file in 3 fixed locations:

  1. in an actions folder along side the executable
  2. in an actions folder within the projects folder
  3. in an actions folder within our plugin

When exporting the project the actions folder will be exported as well so in runtime it always exists alongside the exe

Fixes #95

Copy link
Collaborator

@beniwtv beniwtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far, will test these on Linux in a bit too.

@BastiaanOlij
Copy link
Member Author

Ok guys, I think I got this working right now.

I'll need to update the documentation accordingly but it will now copy the actions files on export into a folder put alongside the executable.

Only tested this one Windows so would be cool if people test this on other platforms too.

@BastiaanOlij BastiaanOlij marked this pull request as ready for review August 28, 2020 10:22
@beniwtv
Copy link
Collaborator

beniwtv commented Aug 28, 2020

Will test it this evening and let you know

@beniwtv
Copy link
Collaborator

beniwtv commented Aug 28, 2020

Looks good, everything seemed to work for me.

@BastiaanOlij
Copy link
Member Author

Looks good, everything seemed to work for me.

Then I think it's time to merge this in :)

@BastiaanOlij BastiaanOlij merged commit 42ff426 into GodotVR:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported games are unable to find actions.json
2 participants