Improved extension checking logic #87
Conversation
BastiaanOlij
force-pushed
the
improve_enable_extensions
branch
from
7966364
to
24ba595
Compare
|
I also snuck in setting the view configuration type... |
BastiaanOlij
force-pushed
the
improve_enable_extensions
branch
from
24ba595
to
ab79a58
Compare
BastiaanOlij
force-pushed
the
improve_enable_extensions
branch
from
ab79a58
to
3795281
Compare
| }; break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Shouldn't we just return the XR view configuration types values as is? What's the advantage for defining another set of values that map to them especially since the plan is to include as much of OpenXR as possible in Godot 4.x?
There was a problem hiding this comment.
I missed this comment which seems to make the case for it: so our dropdown in the UI works properly.
Seems fine by me if that's the only available option.
There was a problem hiding this comment.
Yeah it's just that for a enum dropdown in the UI you define the property like so:
register_property<OpenXRConfig, int>("view_configuration", ... , GODOT_PROPERTY_HINT_ENUM, "Mono,Stereo");
So 0 = Mono, 1 = Stereo, etc.
Also at some point we will have to think of how we'll unify some of this in Godot 4. We'll likely end up with our own enumerations in the core of Godot for this that map to whatever systems and capabilities that are in place in the runtime. While I'd like to think everyone will switch to OpenXR and we don't have to worry about any other runtimes, I think that is wishful thinking.
This changes the logic that checks and enabled extensions in our plugin.
It works with a
mapto which we add the extensions we want.The entry then points to a boolean that the logic either sets or clears depending on whether the extension is available.
If this pointer is a
nullptrwe deem the extension as a requirement and it not being available will fail initialization of the plugin.Finally we enabled all extensions that were requested and found.
The boolean flags allow further logic to actually implement the usage of the extension.
I've also moved most of the FB extensions out of the Android only sphere, I suspect a number of these will become extensions also implemented by other vendors as has happened with a number of Microsoft and Valve extensions that still bear their names (especially around refresh rates and such, really weird those aren't part of the core spec already).