Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Android api layer #93

Merged
merged 4 commits into from
Sep 15, 2021
Merged

Conversation

m4gr3d
Copy link
Collaborator

@m4gr3d m4gr3d commented Sep 14, 2021

  • The first commit puts the foundation in place to add the Android layer version of the Godot OpenXR api. It's mostly empty for now asides from Godot's plugin setup utilities.
  • The second commit adds an Android module which can be used to quickly build and run the demo project from within Android Studio. The demo project itself is not modified by the process. This will help facilitate and speed up development/debugging of the plugin.

@m4gr3d m4gr3d added android Applies specifically to Android OS enhancement New feature or request Oculus Related to Oculus Runtime (including mobile) labels Sep 15, 2021
@m4gr3d
Copy link
Collaborator Author

m4gr3d commented Sep 15, 2021

@BastiaanOlij Is it possible to omit a directory from scons?
The src/jni directory added in this PR needs to be omitted since it's only valid for Android builds.

@BastiaanOlij
Copy link
Member

@BastiaanOlij Is it possible to omit a directory from scons?
The src/jni directory added in this PR needs to be omitted since it's only valid for Android builds.

Already mentioned this in chat but for completeness sake. For scons you just need to write out these three lines in more detail instead of relying on wildchars:

sources += Glob('src/*.cpp')
sources += Glob('src/*/*.cpp')
sources += Glob('src/*/*/*.cpp')

And make similar changes for cmake:
https://github.com/GodotVR/godot_openxr/blob/master/android/CMakeLists.txt#L104

@BastiaanOlij
Copy link
Member

Also can you add some info to the readme about debugging from Android Studio. I always forget the details about this :)

Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@m4gr3d m4gr3d merged commit 0d33279 into GodotVR:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Applies specifically to Android OS enhancement New feature or request Oculus Related to Oculus Runtime (including mobile)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants