Qt 5.8 is suficient for Python

.. also add examples in gcconfig.pri.in for Windows builds
GoldenCheetah · Nov 24, 2017 · 843180f · 843180f
1 parent ab82ea0
commit 843180f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/gcconfig.pri.in b/src/gcconfig.pri.in
@@ -26,9 +26,14 @@
 # python3.6-config --libs
 #
 #DEFINES += GC_WANT_PYTHON
+# below 3 lines work well on Linux style OS
 #PYTHONHEADER = \<python3.6/Python.h\>
 ##PYTHONINCLUDES = -I/usr/include
 #PYTHONLIBS = -L/usr/lib/python3.6/config-3.6m-x86_64-linux-gnu -lpython3.6m
+# below 3 lines work well on Windows
+#PYTHONHEADER = \"<Python.h>\"
+#PYTHONINCLUDES = -I\"C:\Program Files\Python36\include\"
+#PYTHONLIBS = -L\"C:\Program Files\Python36\libs\" -lpython36
 
 # put output into a separate dir
 # to keep main directory clear

diff --git a/src/src.pro b/src/src.pro
@@ -270,14 +270,14 @@ RESOURCES = $${PWD}/Resources/application.qrc $${PWD}/Resources/RideWindow.qrc
 ### OPTIONAL => Embed Python
 ###=========================
 
-notsupported = "INFO: Embedded Python requires version QT >= 5.9, no support for"
+notsupported = "INFO: Embedded Python requires version QT >= 5.8, no support for"
 notsupported += $${QT_VERSION}
 
 contains(DEFINES, "GC_WANT_PYTHON") {
 
     greaterThan(QT_MAJOR_VERSION, 4) {
 
-        greaterThan(QT_MINOR_VERSION, 8) {
+        greaterThan(QT_MINOR_VERSION, 7) {
 
             # add Python subdirectory to include path
             INCLUDEPATH += ./Python