Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSS per hour averaging problems in Metrics Trends charts #2508

Closed
amtriathlon opened this issue May 5, 2017 · 2 comments
Closed

TSS per hour averaging problems in Metrics Trends charts #2508

amtriathlon opened this issue May 5, 2017 · 2 comments

Comments

@amtriathlon
Copy link
Member

The problem was reported at the forum (https://groups.google.com/d/msg/golden-cheetah-users/0mrLR07rxIs/RewazEhXAwAJ) and it seems to be due to the TSS per hour metric set count to hours while LTMPlot averaging assumes count is an integer number of seconds.
Two solutions possible solutions:

  1. change LTMPlot to remove that assumption and allows count to be a double
  2. change TSS per hour metric to be like other metrics where count is seconds and document count should be seconds, even for custom metrics.
@liversedge
Copy link
Member

I'd keep things simple and set count to seconds. Anything else runs the risk of introducing a regression.

Not sure why count would be assumed to be seconds !

@liversedge liversedge added this to the 3.5 milestone May 5, 2017
@liversedge liversedge added the P2 label May 5, 2017
@amtriathlon
Copy link
Member Author

The assumption in Metric Trends is count is an integer value, not necessarily seconds, lets got with the simpler solution.

liversedge pushed a commit that referenced this issue Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants