QwtPlotGappedCurve: Include the last point in the plot #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccioclista
force-pushed
the
fix_QwtPlotGappedCurve_upper_bound
branch
from
b334e79
to
16f4b9a
Compare
riccioclista
force-pushed
the
fix_QwtPlotGappedCurve_upper_bound
branch
from
16f4b9a
to
90688f2
Compare
amtriathlon
approved these changes
Apr 1, 2020
human705
pushed a commit
to human705/GoldenCheetah
that referenced
this pull request
May 13, 2020
…#2678) Also solves the same issue is present when plotting Measures in Trends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last line in QwtPlotGappedCurve is omitted, which leaves the graph unfinished as can be seen in this graph of PMax (CP History):
Extending the upper bound to include all data points fixes this.
QwtPlotGappedCurve is also used for the power plot in AllPlot. However, the effect on AllPlot is minimal (if not even beneficial):