The cli_wallet does not correctly create transaction.

[kotbegemot]

Steps to reproduce

Actual results

Expected result
cli_wallet returns success on create an account.

[zxcat]

It's not cli_wallet problem, JSON-RPC network_broadcast_api broadcast_transaction fails the same way

[afalaleev]

@zxcat Yes, you are right the problem is in compatibility with old protocol. Tomorrow, we will create an issue with returning of old protocol for network_broadcast_api.

[zxcat]

@afalaleev, yeah, I've already discovered it, here is my hotfix #399

[zxcat]

Note: #399 fixes only broadcast_transaction (I checked this method via websockets). But cli_wallet uses broadcast_transaction_synchronous, which still don't work. There is something else broken in addition to input parameters, so cli_wallet transaction expires and golosd crashes.

[zxcat]

works for me now for good transactions. still crashes if transaction can't be executed (e.g. trying to transfer more funds than have)

[afalaleev]

@zxcat can you show an example of transaction which crashes?

[afalaleev]

@zxcat can you confirm that you are see the same as described in #402.

[zxcat]

cli_wallet looks ok now, but golosd either crashes or spams with exception loop and crashes then.
Steps to reproduce:

1. I run testnet, cyberfounder user have no GBG.
2. Run cli_wallet -C "unlock 123 && transfer cyberfounder \"null\" \"0.123 GBG\" \"{}\" true"
   Result:
   

560008ms th_a       network_broadcast_api.cpp:162 on_applied_block     ] 13 N5boost16exception_detail10clone_implINS0_19error_info_injectorINS_10lock_errorEEEEE: boost: mutex lock failed in pthread_mutex_lock: Invalid argument
rethrow boost: mutex lock failed in pthread_mutex_lock: Invalid argument:
    {"what":"boost: mutex lock failed in pthread_mutex_lock: Invalid argument"}
    th_a  network_broadcast_api.cpp:162 on_applied_block
1560008ms th_a       database.cpp:1012             notify_applied_block ] Caught exception in plugin: 13 N5boost16exception_detail10clone_implINS0_19error_info_injectorINS_10lock_errorEEEEE: boost: mutex lock failed in pthread_mutex_lock: Invalid argument
rethrow boost: mutex lock failed in pthread_mutex_lock: Invalid argument:
    {"what":"boost: mutex lock failed in pthread_mutex_lock: Invalid argument"}
    th_a  network_broadcast_api.cpp:162 on_applied_block

You can see transactions send by running that command, then some blocks produced, then assertion fail in a promise.

Sometimes it crashes instantly, sometimes starts to spam that error message each block.

3. If it's not crashed yet, executing valid transaction will kill golosd:
   [1] 44278 segmentation fault ../programs/golosd/golosd -d testnet165

[afalaleev]

@zxcat Thank you 👍In your case golosd crashes in the same place as in case from #402

[zxcat]

@afalaleev, yeah, looks the same