Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One time links should be generated by our url shortener #496

Closed
sirpy opened this issue Aug 29, 2019 · 6 comments · Fixed by #573
Closed

One time links should be generated by our url shortener #496

sirpy opened this issue Aug 29, 2019 · 6 comments · Fixed by #573
Assignees

Comments

@sirpy
Copy link
Contributor

sirpy commented Aug 29, 2019

give.gdlr.info and get.gdlr.info redirects to the relevant dashboard screens
curl -I give.gdlr.info to verify
Definition of Done

  • only on production
  • give.gdlr.info/code works for requests
  • get.gdlr.info/code works withdrawing
@sirpy
Copy link
Contributor Author

sirpy commented Sep 16, 2019

@Nordwhale this PR has been merged and reverted.
See my last review of the PR.
we have give.gdlr.info and get.gdlr.info type them in the browser and see the destination they are converted too.
need to verify the payment links for send/receive we create are working correctly - see my last comment in the PR

@Nordwhale
Copy link

@sirpy Could you please add more details how give.gdlr.info/code and
get.gdlr.info/code should work? What is the whole flow and how they are used?

I see that it redirects to receive and withdraw. It works good for me on Production. But what is the initial task and what's wrong in current implementation with the code parameter?

@sirpy
Copy link
Contributor Author

sirpy commented Sep 17, 2019

they are just short urls for the receive/send links we use.
the problem is that kevin creates the links by appending the url params to the url for example
/dashboard/Send is appended with '?code=X' while the short url expected X to be appended without '?code='
get.gdlr.info/X
get/give.gdlr.info are configured on cloudflare to redirect to dapp.gooddollar.org/Dashboard/Send?code=X
so i'm not sure the creation of the payment link is universal meaning that it will work ok both on production which should use get/give.gdlr.info and qa/dev which keep using the regular urls.

@Nordwhale
Copy link

We’ve changed forming of links and add conditions for prod and qa/dev. We’ve added two new parameters
REACT_APP_RECEIVE_URL=
REACT_APP_SEND_URL=

For prod they should be
get.gdlr.info/
give.gdlr.info/

There is condition, if it’s Prod, then we add code after slash ( have to add other parameters as well), if dev/qa we add GET parameters.

Payment links params should stay the same on production the only the difference is the format of the link, that the code is in url other params should be the same.

For payment we can simply use dapp.gooddollar.org/?paymentCode=
for receive it should go to the .../Send?code=

@StanislavShevchenko
Copy link
Contributor

need add to env
REACT_APP_RECEIVE_URL=
REACT_APP_SEND_URL=

Nordwhale pushed a commit that referenced this issue Sep 25, 2019
…me-links-should-be-generated-by-our-url-shortener
Nordwhale pushed a commit that referenced this issue Sep 25, 2019
…nerated-by-our-url-shortener' into #496-One-time-links-should-be-generated-by-our-url-shortener
StanislavShevchenko added a commit that referenced this issue Sep 29, 2019
…me-links-should-be-generated-by-our-url-shortener
sirpy pushed a commit that referenced this issue Oct 2, 2019
* #496 One time links should be generated by our url shortener

* For payment we can simply use dapp.gooddollar.org/?paymentCode=
For receive it should go to the .../Send?code=

* double encodeURI

* fix double condition

* editing tests

* editing tests

* fix in PR comments
1 EncodeURI procedure transfer
2 Change default value

* fix by comments
@qatests1001
Copy link

Checked on https://goodqa.netlify.com
goodqa.netlify.com/AppNavigation/Dashboard/Home?paymentCode=
goodqa.netlify.com/AppNavigation/Dashboard/Send?code=

Checked on https://gooddev.netlify.com
gooddev.netlify.com/?paymentCode=
gooddev.netlify.com/?code=

@sirpy sirpy closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants