-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One time links should be generated by our url shortener #496
Comments
@Nordwhale this PR has been merged and reverted. |
@sirpy Could you please add more details how give.gdlr.info/code and I see that it redirects to receive and withdraw. It works good for me on Production. But what is the initial task and what's wrong in current implementation with the code parameter? |
they are just short urls for the receive/send links we use. |
We’ve changed forming of links and add conditions for prod and qa/dev. We’ve added two new parameters For prod they should be There is condition, if it’s Prod, then we add code after slash ( have to add other parameters as well), if dev/qa we add GET parameters. Payment links params should stay the same on production the only the difference is the format of the link, that the code is in url other params should be the same. For payment we can simply use dapp.gooddollar.org/?paymentCode= |
need add to env |
…me-links-should-be-generated-by-our-url-shortener
…nerated-by-our-url-shortener' into #496-One-time-links-should-be-generated-by-our-url-shortener
…me-links-should-be-generated-by-our-url-shortener
* #496 One time links should be generated by our url shortener * For payment we can simply use dapp.gooddollar.org/?paymentCode= For receive it should go to the .../Send?code= * double encodeURI * fix double condition * editing tests * editing tests * fix in PR comments 1 EncodeURI procedure transfer 2 Change default value * fix by comments
Checked on https://goodqa.netlify.com Checked on https://gooddev.netlify.com |
give.gdlr.info and get.gdlr.info redirects to the relevant dashboard screens
curl -I give.gdlr.info to verify
Definition of Done
The text was updated successfully, but these errors were encountered: