#496 One time links should be generated by our url shortener #615
Conversation
StanislavShevchenko
requested review from
sirpy,
AlexeyKosinski and
yaroslav-fedyshyn-nordwhale
There was a problem hiding this comment.
@StanislavShevchenko re-read the issue
and address all problems raised there
For receive it should go to the .../Send?code=
There was a problem hiding this comment.
@Nordwhale @StanislavShevchenko
do we still need to make the link with the whole path? ie /Applicaiton/Dashboard/Receive?code=
or is it enough to use /?paymentCode= and /?code= ?
Yes, now it’s enough to have a link |
Sorry, maybe clicked |
done |
| @@ -89,9 +89,9 @@ describe('generateShareLink', () => { | |||
| const params = { key: 'value with spaces' } | |||
|
|
|||
| // When | |||
| const link = generateShareLink(action, params) | |||
| const link = encodeURI(generateShareLink(action, params)) | |||
There was a problem hiding this comment.
The link that we generate should be already encoded.
This suggest there are probably issues at the code where we use links that are not encoded.
I suggest we change the generateShareLink to encode the uri and remove encodeuri from other places
There was a problem hiding this comment.
The generateShareObject method does encodeURI that breaks the reference in Share Object . But most likely it is necessary to remove reuse in the generateShareObject method
| const Config = { | ||
| env: process.env.REACT_APP_ENV || 'development', | ||
| version: process.env.VERSION || 'v0', | ||
| logLevel: process.env.REACT_APP_LOG_LEVEL || 'debug', | ||
| serverUrl: process.env.REACT_APP_SERVER_URL || 'http://localhost:3003', | ||
| gunPublicUrl: process.env.REACT_APP_GUN_PUBLIC_URL || 'http://localhost:3003/gun', | ||
| web3SiteUrl: process.env.REACT_APP_WEB3_SITE_URL || 'https://w3.gooddollar.org', | ||
| publicUrl: process.env.REACT_APP_PUBLIC_URL || (window && window.location && window.location.origin), | ||
| publicUrl, |
There was a problem hiding this comment.
It is defined above in this file
1 EncodeURI procedure transfer 2 Change default value
…me-links-should-be-generated-by-our-url-shortener
…nerated-by-our-url-shortener' into #496-One-time-links-should-be-generated-by-our-url-shortener
…me-links-should-be-generated-by-our-url-shortener
sirpy
deleted the
#496-One-time-links-should-be-generated-by-our-url-shortener
branch
#496
One time links should be generated by our url shortener
We’ve changed forming of links and add conditions for prod and qa/dev. We’ve added two new parameters
REACT_APP_RECEIVE_URL=
REACT_APP_SEND_URL=
For prod they should be
get.gdlr.info/
give.gdlr.info/
There is condition, if it’s Prod, then we add code after slash ( have to add other parameters as well), if dev/qa we add GET parameters.
Payment links params should stay the same on production the only the difference is the format of the link, that the code is in url other params should be the same.
For payment we can simply use dapp.gooddollar.org/?paymentCode=
for receive it should go to the .../Send?code=
And removed double encodeURI