(Feature) #1014 improve payment confirmation screen send receive #1084

yaroslav-fedyshyn-nordwhale · 2019-12-19T15:34:20Z

Description

Change the layout and styles for SendSummary, SendConfirmation, ReceiveSummary, ReceiveCOnfirmation component to make them look according to the new design.

About #1014

How Has This Been Tested?

Try to create 'receive specific amount' or 'send' link. See the new updated design for the screens.

Checklist:

Screenshots

Receive Summary:

	Browser	Simulators
Without Creds
With 1 Cred
With 2 Creds

Receive Confirmation:

	Browser	Simulators
Without Reason
Within Reason

Send Summary:

	Browser	Simulators
Without Reason
Within Reason

Send Confirmation:

Available only for the desktop app. On mobile, it is working through share dialog.

Without Reason	With Reason	Done state

…creen according new design

LiavGut

Basically, my main issue is with the margin between elements on the screen.
It's regarding:

Receive Summary
Receive Confirmation
Send Confirmation (Desktop)

If it's based on formula then it's not always working.
The elements should be more close to each other and then (as a group) they should be vertically aligned from the top bar to the button.

Hope it's clear, if you have any questions, feel free to talk with me.
Thanks

sirpy · 2019-12-22T14:25:56Z

Do you want space between elements to be fixed like in design and just vertically centered? or the space between them should grow relative to screen size?

LiavGut · 2019-12-22T14:49:37Z

@sirpy The best option is somewhere in between :)|
Basically, fixed like the design, but in the bigger (the tall and the narrow) devices and in the desktop, we could enlarge a bit the margins. Maybe we can decide from what screen size should be changed.

sirpy · 2019-12-22T18:25:46Z

best way is to do it with a formula like keeping the design ratio for larger screens

… screen

…reen

yaroslav-fedyshyn-nordwhale · 2019-12-23T11:13:30Z

@LiavGut The new fixed applied (as we discussed):

Receive Summary:

	Browser	Simulators
Without Reason
Within Reason

Receive Confirmation:

Browser	Simulators

Send Confirmation:

Only desktop.

Without Reason	Within Reason

sirpy

getrelativesize with second param set to true doesnt change the relative size for larger screens
does normalize still do something?

yaroslav-fedyshyn-nordwhale · 2019-12-24T08:39:20Z

getrelativesize with second param set to true doesnt change the relative size for larger screens
does normalize still do something?

yes

yaroslav-fedyshyn-nordwhale · 2019-12-24T20:27:05Z

@sirpy I tried to add the second parameter false to the getRelativeDesignHeigh fn and it starts looking horrible on large devices. The margins become too big and it starts looking not symmetric. So I don't think that we need to use the second arg as it looking good with the current changes we discussed with Liav.

sirpy · 2019-12-24T21:27:52Z

@sirpy I tried to add the second parameter false to the getRelativeDesignHeigh fn and it starts looking horrible on large devices. The margins become too big and it starts looking not symmetric. So I don't think that we need to use the second arg as it looking good with the current changes we discussed with Liav.

We need to see how it looks, why would margins become too big? if they are 20 they might become 30, if they are 15 than maybe 22, i dont see how that is too big. why wouldnt it be symmetric? if margins between items are the same and all items are centered in page as a group

…e the space between element be responsive on larger devices.

yaroslav-fedyshyn-nordwhale · 2019-12-26T11:06:13Z

@sirpy I tried to add the second parameter false to the getRelativeDesignHeigh fn and it starts looking horrible on large devices. The margins become too big and it starts looking not symmetric. So I don't think that we need to use the second arg as it looking good with the current changes we discussed with Liav.

We need to see how it looks, why would margins become too big? if they are 20 they might become 30, if they are 15 than maybe 22, i dont see how that is too big. why wouldnt it be symmetric? if margins between items are the same and all items are centered in page as a group

I pushed new commit with fixes

sirpy

@yaroslav-fedyshyn-nordwhale the last images you sent how are liav wants it
please attach images to see how it looks after last change (false added to relativedesign)

yaroslav-fedyshyn-nordwhale · 2020-01-10T06:45:49Z

@sirpy here is the images with latest (false added to relativeDesign) changes:

SendConfirmation	SendSummary	ReceiveSummary

… component

sirpy · 2020-01-10T10:01:22Z

@yaroslav-fedyshyn-nordwhale same screens with "true" please also for comparison

yaroslav-fedyshyn-nordwhale · 2020-01-10T13:25:19Z

With true second parameter:

Send Confirmation	SendSummary	ReceiveSummary

sirpy · 2020-01-12T07:24:43Z

@LiavGut which set do you prefer?

LiavGut · 2020-01-12T07:47:37Z

@LiavGut which set do you prefer?

@sirpy The on with true second parameter

yaroslav-fedyshyn-nordwhale · 2020-01-13T07:15:52Z

@sirpy then I am going to revert the changes with second designRelative parameter to true. and fix the conflicts, ok?

sirpy · 2020-01-13T07:53:27Z

ok

This reverts commit b2bef1b

…kSummary component" This reverts commit 36468ec

…n to make the space between element be responsive on larger devices." This reverts commit 113f84a

…end_Receive # Conflicts: # src/components/sidemenu/__tests__/__snapshots__/SideMenuPanel.js.snap

yaroslav-fedyshyn-nordwhale · 2020-01-13T10:56:23Z

@sirpy then I am going to revert the changes with second designRelative parameter to true. and fix the conflicts, ok?

Done

* feat(UI): the next button is overlapped by system keyboard on the sign up screen (#1064) * add condition for min hight for smal screen * add hook to use Keyboard * added isMobileKeyboardShown to simpleStore after focused on input * added isMobileKeyboardShown to simpleStore after focused on input * hide btn from mobile and tablet * check autoFocus * autoFocus only desktop * fixed autoFocus only mobile * fixed snapshot and hidden btn in phone screen * down btn on focus * increase the height of the screen by focus in the input * fixed only Iphone5 * fixed only Iphone5 * fixed snapshots * uses onTouchstart * revert signupwrapper * call onFocus if is mobile * commit for test android * remove css and add condition for android and ISO * fixed snapshots * trying add scroll on android * change minHeight only for android * refactor: save original device height and use * refactor: moved originalScreenHeight to Orientation.js Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> * feat: Improve the settings menu and add easy access via the top bar (#1144) * Improve the settings menu and add easy access via the top bar * change the size of the icons and change margin between the 2 buttons * refactor: renaming, fixed size, added params * refactor: remove custom size, update icons * refactor: showMenuItem > showInMainMenu * refactor: rename showInMainMenu = showAddWebAppDialog * fix snapshots Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> * Keep web behaviour * (Chore) #1090 Hotfix: Change webapp favicon (#1172) * fix: add new favicon icons. change the icon urls in manifest.json nad index.js files * fix: add new favicon icons for iphones. change the icon urls in manifest.json nad index.js files * (Feature) #1014 improve payment confirmation screen send receive (#1084) * add: make the send screen to match design * add: implement the new design for SendLink screen * add: implement the new design for SendConfirmation screen * add: change the naming for jss styles, Implement the ReceiveSummary screen according new design * add: Implement the ReceiveConfirmation screen according new design * fix: update snapshots * fix: make space between group/elements smaller on ReceiveConfirmation screen * fix: make space between group/elements smaller on SendConfirmation screen * fix: make space between group/elements smaller on ReceiveSummary screen * fix: update snapshots * fix: add new test to pass travis build * fix: update snapshot * fix: add second parameter false for getDesignRelativeHeight fn to make the space between element be responsive on larger devices. * fix: add second parameter false for relativeDesign in sendLinkSummary component * fix: update snapshots * Revert "fix: update snapshots" This reverts commit b2bef1b * Revert "fix: add second parameter false for relativeDesign in sendLinkSummary component" This reverts commit 36468ec * Revert "fix: add second parameter false for getDesignRelativeHeight fn to make the space between element be responsive on larger devices." This reverts commit 113f84a * (Feature) #1094 update sign in screen design text (#1183) * fix: change the design and text for signin screen according to the new design * fix: update snapshots * added web compiling scripts & fixed prefetch & web dependent code * stable web wip * getting proper styles on dashboard & loading swipeable list on web * remove snapshots * remove snapshot Co-authored-by: StanislavShevchenko <stas246978@gmail.com> Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> Co-authored-by: yaroslav-fedyshyn-nordwhale <49862004+yaroslav-fedyshyn-nordwhale@users.noreply.github.com>

* feat(UI): the next button is overlapped by system keyboard on the sign up screen (#1064) * add condition for min hight for smal screen * add hook to use Keyboard * added isMobileKeyboardShown to simpleStore after focused on input * added isMobileKeyboardShown to simpleStore after focused on input * hide btn from mobile and tablet * check autoFocus * autoFocus only desktop * fixed autoFocus only mobile * fixed snapshot and hidden btn in phone screen * down btn on focus * increase the height of the screen by focus in the input * fixed only Iphone5 * fixed only Iphone5 * fixed snapshots * uses onTouchstart * revert signupwrapper * call onFocus if is mobile * commit for test android * remove css and add condition for android and ISO * fixed snapshots * trying add scroll on android * change minHeight only for android * refactor: save original device height and use * refactor: moved originalScreenHeight to Orientation.js Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> * feat: Improve the settings menu and add easy access via the top bar (#1144) * Improve the settings menu and add easy access via the top bar * change the size of the icons and change margin between the 2 buttons * refactor: renaming, fixed size, added params * refactor: remove custom size, update icons * refactor: showMenuItem > showInMainMenu * refactor: rename showInMainMenu = showAddWebAppDialog * fix snapshots Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> * (Chore) #1090 Hotfix: Change webapp favicon (#1172) * fix: add new favicon icons. change the icon urls in manifest.json nad index.js files * fix: add new favicon icons for iphones. change the icon urls in manifest.json nad index.js files * (Feature) #1014 improve payment confirmation screen send receive (#1084) * add: make the send screen to match design * add: implement the new design for SendLink screen * add: implement the new design for SendConfirmation screen * add: change the naming for jss styles, Implement the ReceiveSummary screen according new design * add: Implement the ReceiveConfirmation screen according new design * fix: update snapshots * fix: make space between group/elements smaller on ReceiveConfirmation screen * fix: make space between group/elements smaller on SendConfirmation screen * fix: make space between group/elements smaller on ReceiveSummary screen * fix: update snapshots * fix: add new test to pass travis build * fix: update snapshot * fix: add second parameter false for getDesignRelativeHeight fn to make the space between element be responsive on larger devices. * fix: add second parameter false for relativeDesign in sendLinkSummary component * fix: update snapshots * Revert "fix: update snapshots" This reverts commit b2bef1b * Revert "fix: add second parameter false for relativeDesign in sendLinkSummary component" This reverts commit 36468ec * Revert "fix: add second parameter false for getDesignRelativeHeight fn to make the space between element be responsive on larger devices." This reverts commit 113f84a * (Feature) #1094 update sign in screen design text (#1183) * fix: change the design and text for signin screen according to the new design * fix: update snapshots * Add test for checking menu (#1196) * update selectors * added tests for checking topbar items * add IDs on topbar items * use selectors in tests * fix selectors * fix selector * remove clicking on submit button * fix snapshoots Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> * added logic only for testing a task #935 (#1223) * chore: release version 0.13.1-0 [skip ci] * chore: release version 0.13.1-1 [skip ci] * chore: release version 0.13.1-2 [skip ci] * chore: release version 0.13.1-3 [skip ci] * chore: release version 0.13.1-4 [skip ci] * chore: release version 0.13.1-5 [skip ci] * chore: release version 0.13.1-6 [skip ci] * chore: release version 0.13.1-7 [skip ci] * chore: release version 0.13.1-8 [skip ci] * chore: release version 0.13.1-9 [skip ci] * chore: release version 0.13.1-10 [skip ci] * chore: release version 0.13.1-11 [skip ci] * chore: release version 0.13.1-12 [skip ci] * chore: release version 0.13.1-13 [skip ci] * fix: handle undefined * add: dont log.error otp failures * (Feature) #1142 Dashboard - the transition between regular dashboard and scroll dashboard should be more smooth with animations (#1228) * add: add animation for switching between large and small header on dashboard page * fix: update snapshots * add: implement the animation for dahsboard header according to the new requirements * fix: add easing for animations, decrease the duration for fade animation of full name * add: make the x button do the same as later button on add web app popup (#1259) * fix: add condition to prevent error occurring while trying to set empty token to the gun (#1260) * add topbar tests (#1240) * (Bug) #1149 The "Next" button is active before entering phone number (#1266) * fix: improve the validation functionality for phone number field on registration flow * fix: update snapshots * hasConnection bindevents called multiple times#1155 (#1267) * once add bindevents and remove if lose connection * use a fixed reference to the callback method. * Fixed snapshots * Revert "Fixed snapshots" This reverts commit 3b1ac99 * (BUG) The survey pop-up in the Send flow is broken (#1274) * testing dialog windows * set to ModalOverlay original screen width * set 100% to width * Fixed snapshots * (Bug) #1130 Payment link "cancel failed" disappeared from feed (#1268) * fix: add restore feed status in catch clause while cancel link failed * fix: add restore feed status in catch clause while cancel link failed for quick action functionality * fix: fix the erro messages for erro dialog * fix: use the same fn to recover the failed cancel payment tx * fix: mke the error logging match the required convention * chore: release version 0.14.0 [skip ci] * fix: do not report the internet connection error to the bug tracking systems (#1275) * (Bug) #1102 send me the code again not responsive (#1127) * fix: show loader when waiting for send code again * button spinner * add spinner+check animation * added spinner to emailConfirm screen * redevelop to lottie-react-web and segments * redevelop to function component, remove onFrame callback * try to fix canvas + jest * move convas prebuild to dep * add node-pre-gyp * fix double execution onFinish * change to lottie-react-native * wip: test without effects * fix: unnecessary re-rendering of sms resend button hurting animation * add: speedup animation on finish * fix: reset state correctly * fix: call setSpeed only once Co-authored-by: StanislavShevchenko <stas246978@gmail.com> Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> Co-authored-by: sirpy <hadarr@gmail.com> * Unable to load wallet is displayed and is unrecoverable (#1283) * Unable to load wallet is displayed and is unrecoverable * show dialog after the first attempt to restart * (Feature) #1143 Feed: upload feed card animation (#1238) * add: implement the animation for loading (empty) feed items * fix: make the animation perform in 2 seconds and only on fisrt load * fix: fix tests * fix: remove the lag for loading feed animation by using some animation optimizations and increasing the time for addWebApp functionality delay * fix: after merge fix * fix: create custom animation schema to increase animation range, make the animation perform faster * (Bug) #1284 The wallet UI is displayed incorrectly (#1287) * fix: remove unnecessary horizontal scroll from welcome screen * fix: fix the centering of the big number on dashboard header * fix: update snapshots * fix: add explanation comment to the saveBalanceBlockWidth fn * fix: remove used vw size parameter * chore: release version 0.14.1-0 [skip ci] * chore: release version 0.14.1-1 [skip ci] * chore: release version 0.14.1-2 [skip ci] * Handle web3 errors gracefully (not open on send) (#1250) * Handle web3 errors gracefully (not open on send) * refactor: by PR comments, rename, added loger, throw error * Update SendQRSummary.js * refactor: removed errorMessageTryAgainFromAppSwitch from global.Store * refactor: Message improved, log format changed, retry set * refactor: added human reason, remove loop, new message * change error messages and remove boldMessage params Co-authored-by: sirpy <hadarr@gmail.com> * fix merge * fix merge * fix merge Co-authored-by: StanislavShevchenko <stas246978@gmail.com> Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> Co-authored-by: yaroslav-fedyshyn-nordwhale <49862004+yaroslav-fedyshyn-nordwhale@users.noreply.github.com> Co-authored-by: Andrew Lebowski <47723945+AndrewLebowski@users.noreply.github.com> Co-authored-by: sirpy <hadarr@gmail.com>

* feat(UI): the next button is overlapped by system keyboard on the sign up screen (#1064) * add condition for min hight for smal screen * add hook to use Keyboard * added isMobileKeyboardShown to simpleStore after focused on input * added isMobileKeyboardShown to simpleStore after focused on input * hide btn from mobile and tablet * check autoFocus * autoFocus only desktop * fixed autoFocus only mobile * fixed snapshot and hidden btn in phone screen * down btn on focus * increase the height of the screen by focus in the input * fixed only Iphone5 * fixed only Iphone5 * fixed snapshots * uses onTouchstart * revert signupwrapper * call onFocus if is mobile * commit for test android * remove css and add condition for android and ISO * fixed snapshots * trying add scroll on android * change minHeight only for android * refactor: save original device height and use * refactor: moved originalScreenHeight to Orientation.js Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> * feat: Improve the settings menu and add easy access via the top bar (#1144) * Improve the settings menu and add easy access via the top bar * change the size of the icons and change margin between the 2 buttons * refactor: renaming, fixed size, added params * refactor: remove custom size, update icons * refactor: showMenuItem > showInMainMenu * refactor: rename showInMainMenu = showAddWebAppDialog * fix snapshots Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> * (Chore) #1090 Hotfix: Change webapp favicon (#1172) * fix: add new favicon icons. change the icon urls in manifest.json nad index.js files * fix: add new favicon icons for iphones. change the icon urls in manifest.json nad index.js files * (Feature) #1014 improve payment confirmation screen send receive (#1084) * add: make the send screen to match design * add: implement the new design for SendLink screen * add: implement the new design for SendConfirmation screen * add: change the naming for jss styles, Implement the ReceiveSummary screen according new design * add: Implement the ReceiveConfirmation screen according new design * fix: update snapshots * fix: make space between group/elements smaller on ReceiveConfirmation screen * fix: make space between group/elements smaller on SendConfirmation screen * fix: make space between group/elements smaller on ReceiveSummary screen * fix: update snapshots * fix: add new test to pass travis build * fix: update snapshot * fix: add second parameter false for getDesignRelativeHeight fn to make the space between element be responsive on larger devices. * fix: add second parameter false for relativeDesign in sendLinkSummary component * fix: update snapshots * Revert "fix: update snapshots" This reverts commit b2bef1b * Revert "fix: add second parameter false for relativeDesign in sendLinkSummary component" This reverts commit 36468ec * Revert "fix: add second parameter false for getDesignRelativeHeight fn to make the space between element be responsive on larger devices." This reverts commit 113f84a * (Feature) #1094 update sign in screen design text (#1183) * fix: change the design and text for signin screen according to the new design * fix: update snapshots * Add test for checking menu (#1196) * update selectors * added tests for checking topbar items * add IDs on topbar items * use selectors in tests * fix selectors * fix selector * remove clicking on submit button * fix snapshoots Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> * added logic only for testing a task #935 (#1223) * chore: release version 0.13.1-0 [skip ci] * chore: release version 0.13.1-1 [skip ci] * chore: release version 0.13.1-2 [skip ci] * chore: release version 0.13.1-3 [skip ci] * chore: release version 0.13.1-4 [skip ci] * chore: release version 0.13.1-5 [skip ci] * chore: release version 0.13.1-6 [skip ci] * chore: release version 0.13.1-7 [skip ci] * chore: release version 0.13.1-8 [skip ci] * chore: release version 0.13.1-9 [skip ci] * chore: release version 0.13.1-10 [skip ci] * chore: release version 0.13.1-11 [skip ci] * chore: release version 0.13.1-12 [skip ci] * chore: release version 0.13.1-13 [skip ci] * fix: handle undefined * add: dont log.error otp failures * (Feature) #1142 Dashboard - the transition between regular dashboard and scroll dashboard should be more smooth with animations (#1228) * add: add animation for switching between large and small header on dashboard page * fix: update snapshots * add: implement the animation for dahsboard header according to the new requirements * fix: add easing for animations, decrease the duration for fade animation of full name * add: make the x button do the same as later button on add web app popup (#1259) * fix: add condition to prevent error occurring while trying to set empty token to the gun (#1260) * add topbar tests (#1240) * (Bug) #1149 The "Next" button is active before entering phone number (#1266) * fix: improve the validation functionality for phone number field on registration flow * fix: update snapshots * hasConnection bindevents called multiple times#1155 (#1267) * once add bindevents and remove if lose connection * use a fixed reference to the callback method. * Fixed snapshots * Revert "Fixed snapshots" This reverts commit 3b1ac99 * (BUG) The survey pop-up in the Send flow is broken (#1274) * testing dialog windows * set to ModalOverlay original screen width * set 100% to width * Fixed snapshots * (Bug) #1130 Payment link "cancel failed" disappeared from feed (#1268) * fix: add restore feed status in catch clause while cancel link failed * fix: add restore feed status in catch clause while cancel link failed for quick action functionality * fix: fix the erro messages for erro dialog * fix: use the same fn to recover the failed cancel payment tx * fix: mke the error logging match the required convention * chore: release version 0.14.0 [skip ci] * fix: do not report the internet connection error to the bug tracking systems (#1275) * (Bug) #1102 send me the code again not responsive (#1127) * fix: show loader when waiting for send code again * button spinner * add spinner+check animation * added spinner to emailConfirm screen * redevelop to lottie-react-web and segments * redevelop to function component, remove onFrame callback * try to fix canvas + jest * move convas prebuild to dep * add node-pre-gyp * fix double execution onFinish * change to lottie-react-native * wip: test without effects * fix: unnecessary re-rendering of sms resend button hurting animation * add: speedup animation on finish * fix: reset state correctly * fix: call setSpeed only once Co-authored-by: StanislavShevchenko <stas246978@gmail.com> Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> Co-authored-by: sirpy <hadarr@gmail.com> * Unable to load wallet is displayed and is unrecoverable (#1283) * Unable to load wallet is displayed and is unrecoverable * show dialog after the first attempt to restart * (Feature) #1143 Feed: upload feed card animation (#1238) * add: implement the animation for loading (empty) feed items * fix: make the animation perform in 2 seconds and only on fisrt load * fix: fix tests * fix: remove the lag for loading feed animation by using some animation optimizations and increasing the time for addWebApp functionality delay * fix: after merge fix * fix: create custom animation schema to increase animation range, make the animation perform faster * (Bug) #1284 The wallet UI is displayed incorrectly (#1287) * fix: remove unnecessary horizontal scroll from welcome screen * fix: fix the centering of the big number on dashboard header * fix: update snapshots * fix: add explanation comment to the saveBalanceBlockWidth fn * fix: remove used vw size parameter * chore: release version 0.14.1-0 [skip ci] * chore: release version 0.14.1-1 [skip ci] * chore: release version 0.14.1-2 [skip ci] * Handle web3 errors gracefully (not open on send) (#1250) * Handle web3 errors gracefully (not open on send) * refactor: by PR comments, rename, added loger, throw error * Update SendQRSummary.js * refactor: removed errorMessageTryAgainFromAppSwitch from global.Store * refactor: Message improved, log format changed, retry set * refactor: added human reason, remove loop, new message * change error messages and remove boldMessage params Co-authored-by: sirpy <hadarr@gmail.com> * merge: fix package.json * Delete webpack.config.dev.js * Delete webpack.config.prod.js Co-authored-by: StanislavShevchenko <stas246978@gmail.com> Co-authored-by: Alexey Kosinski <36693645+AlexeyKosinski@users.noreply.github.com> Co-authored-by: yaroslav-fedyshyn-nordwhale <49862004+yaroslav-fedyshyn-nordwhale@users.noreply.github.com> Co-authored-by: Andrew Lebowski <47723945+AndrewLebowski@users.noreply.github.com>

yaroslav-fedyshyn-nordwhale added 6 commits December 19, 2019 12:17

add: make the send screen to match design

bf698f9

add: implement the new design for SendLink screen

14bba88

add: implement the new design for SendConfirmation screen

789c6da

add: change the naming for jss styles, Implement the ReceiveSummary s…

8163f6e

…creen according new design

add: Implement the ReceiveConfirmation screen according new design

f1a9705

fix: update snapshots

214f287

yaroslav-fedyshyn-nordwhale requested a review from sirpy December 19, 2019 15:44

yaroslav-fedyshyn-nordwhale assigned Nordwhale, AlexeyKosinski and LiavGut and unassigned Nordwhale, AlexeyKosinski and LiavGut Dec 19, 2019

yaroslav-fedyshyn-nordwhale requested review from AlexeyKosinski, LiavGut and Nordwhale December 19, 2019 15:45

AlexeyKosinski approved these changes Dec 20, 2019

View reviewed changes

LiavGut suggested changes Dec 22, 2019

View reviewed changes

yaroslav-fedyshyn-nordwhale added 4 commits December 23, 2019 11:06

fix: make space between group/elements smaller on ReceiveConfirmation…

bede3a8

… screen

fix: make space between group/elements smaller on SendConfirmation sc…

d59eda5

…reen

fix: make space between group/elements smaller on ReceiveSummary screen

0d90653

fix: update snapshots

5a26551

yaroslav-fedyshyn-nordwhale requested a review from LiavGut December 23, 2019 11:18

sirpy requested changes Dec 23, 2019

View reviewed changes

yaroslav-fedyshyn-nordwhale requested a review from sirpy December 24, 2019 08:39

fix: add new test to pass travis build

52a8879

LiavGut approved these changes Dec 24, 2019

View reviewed changes

yaroslav-fedyshyn-nordwhale changed the title ~~1014 improve payment confirmation screen send receive~~ (Feature) #1014 improve payment confirmation screen send receive Dec 24, 2019

fix: update snapshot

cfd50b7

fix: add second parameter false for getDesignRelativeHeight fn to mak…

113f84a

…e the space between element be responsive on larger devices.

sirpy requested changes Jan 6, 2020

View reviewed changes

yaroslav-fedyshyn-nordwhale added 2 commits January 10, 2020 10:43

fix: add second parameter false for relativeDesign in sendLinkSummary…

36468ec

… component

fix: update snapshots

b2bef1b

yaroslav-fedyshyn-nordwhale requested a review from sirpy January 13, 2020 07:15

yaroslav-fedyshyn-nordwhale added 4 commits January 13, 2020 12:08

Revert "fix: update snapshots"

7817945

This reverts commit b2bef1b

Revert "fix: add second parameter false for relativeDesign in sendLin…

05f9d4e

…kSummary component" This reverts commit 36468ec

Revert "fix: add second parameter false for getDesignRelativeHeight f…

661b612

…n to make the space between element be responsive on larger devices." This reverts commit 113f84a

Merge branch 'master' into 1014-Improve_Payment_Confirmation_Screen_S…

db9f309

…end_Receive # Conflicts: # src/components/sidemenu/__tests__/__snapshots__/SideMenuPanel.js.snap

sirpy merged commit a31ba5a into master Jan 13, 2020

sirpy deleted the 1014-Improve_Payment_Confirmation_Screen_Send_Receive branch January 13, 2020 13:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Feature) #1014 improve payment confirmation screen send receive #1084

(Feature) #1014 improve payment confirmation screen send receive #1084

yaroslav-fedyshyn-nordwhale commented Dec 19, 2019 •

edited

Loading

LiavGut left a comment •

edited

Loading

sirpy commented Dec 22, 2019 via email

LiavGut commented Dec 22, 2019

sirpy commented Dec 22, 2019 via email

yaroslav-fedyshyn-nordwhale commented Dec 23, 2019 •

edited

Loading

sirpy left a comment •

edited

Loading

yaroslav-fedyshyn-nordwhale commented Dec 24, 2019

yaroslav-fedyshyn-nordwhale commented Dec 24, 2019

sirpy commented Dec 24, 2019

yaroslav-fedyshyn-nordwhale commented Dec 26, 2019

sirpy left a comment

yaroslav-fedyshyn-nordwhale commented Jan 10, 2020 •

edited

Loading

sirpy commented Jan 10, 2020

yaroslav-fedyshyn-nordwhale commented Jan 10, 2020 •

edited

Loading

sirpy commented Jan 12, 2020

LiavGut commented Jan 12, 2020

yaroslav-fedyshyn-nordwhale commented Jan 13, 2020

sirpy commented Jan 13, 2020

yaroslav-fedyshyn-nordwhale commented Jan 13, 2020

(Feature) #1014 improve payment confirmation screen send receive #1084

(Feature) #1014 improve payment confirmation screen send receive #1084

Conversation

yaroslav-fedyshyn-nordwhale commented Dec 19, 2019 • edited Loading

Description

How Has This Been Tested?

Checklist:

Screenshots

Receive Summary:

Receive Confirmation:

Send Summary:

Send Confirmation:

LiavGut left a comment • edited Loading

Choose a reason for hiding this comment

sirpy commented Dec 22, 2019 via email

LiavGut commented Dec 22, 2019

sirpy commented Dec 22, 2019 via email

yaroslav-fedyshyn-nordwhale commented Dec 23, 2019 • edited Loading

Receive Summary:

Receive Confirmation:

Send Confirmation:

sirpy left a comment • edited Loading

Choose a reason for hiding this comment

yaroslav-fedyshyn-nordwhale commented Dec 24, 2019

yaroslav-fedyshyn-nordwhale commented Dec 24, 2019

sirpy commented Dec 24, 2019

yaroslav-fedyshyn-nordwhale commented Dec 26, 2019

sirpy left a comment

Choose a reason for hiding this comment

yaroslav-fedyshyn-nordwhale commented Jan 10, 2020 • edited Loading

sirpy commented Jan 10, 2020

yaroslav-fedyshyn-nordwhale commented Jan 10, 2020 • edited Loading

sirpy commented Jan 12, 2020

LiavGut commented Jan 12, 2020

yaroslav-fedyshyn-nordwhale commented Jan 13, 2020

sirpy commented Jan 13, 2020

yaroslav-fedyshyn-nordwhale commented Jan 13, 2020

yaroslav-fedyshyn-nordwhale commented Dec 19, 2019 •

edited

Loading

LiavGut left a comment •

edited

Loading

yaroslav-fedyshyn-nordwhale commented Dec 23, 2019 •

edited

Loading

sirpy left a comment •

edited

Loading

yaroslav-fedyshyn-nordwhale commented Jan 10, 2020 •

edited

Loading

yaroslav-fedyshyn-nordwhale commented Jan 10, 2020 •

edited

Loading