Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome rewards flow #4279

Merged
merged 12 commits into from
Jul 10, 2024
Merged

Welcome rewards flow #4279

merged 12 commits into from
Jul 10, 2024

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Jun 19, 2024

Description

For a select group of users we want to show a welcome offer when they sign up for wallet-v2.
This PR includes:

  • The WelcomeOfferModal
  • Show Modal based on (TBD) <-- decided on location/web-app use
  • Track in amplitude (invited/seen)

UI

image

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goodwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 7:22pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
gooddollar-delta ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 7:22pm
goodid ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 7:22pm

@L03TJ3 L03TJ3 changed the title wip: track events with posthog Welcome rewards flow Jun 20, 2024
Copy link
Contributor

@sirpy sirpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the welcomeoffer trigger to show it?
Lets discuss again with @decentralauren the posthog events

src/components/common/dialogs/WelcomeOffer.jsx Outdated Show resolved Hide resolved
src/components/faceVerification/standalone/App.jsx Outdated Show resolved Hide resolved
module: 'logs',
action: 'getLogs',
page: '1',
offset: '31',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 31?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't know. I assume I thought for 31 days, but even that does not make any sense in this context.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to 10k which should be default as well

src/components/common/buttons/TaskButton.jsx Outdated Show resolved Hide resolved
src/components/common/buttons/TaskButton.jsx Outdated Show resolved Hide resolved
src/components/common/dialogs/WelcomeOffer.jsx Outdated Show resolved Hide resolved
src/components/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
src/components/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
src/components/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
src/lib/API/api.js Outdated Show resolved Hide resolved
src/lib/wallet/GoodWalletProvider.jsx Outdated Show resolved Hide resolved
src/components/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
- remove unused alt-claim utility
- add: only show offer once a day
- fix: use const declarations for events
- fix: use retry for fetching location
- extend payload variables for feature-flag welcome offer
src/components/dashboard/Dashboard.jsx Outdated Show resolved Hide resolved
@L03TJ3 L03TJ3 merged commit dba9274 into master Jul 10, 2024
10 of 21 checks passed
@L03TJ3 L03TJ3 deleted the 4278-welcome-rewards branch July 10, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants