add deprecation modal #4296
Merged
add deprecation modal #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
@decentralauren Should the 'why' this modal show not show before directing a user to a link? (copy order) |
sirpy
requested changes
Sep 2, 2024
| @@ -40,6 +42,20 @@ export const resetLastSplash = async () => { | |||
| const Splash = ({ animation, isLoggedIn }) => { | |||
| const [checked, setChecked] = useState(false) | |||
| const [shouldAnimate, setShouldAnimate] = useState(isLoggedIn !== true || isMobileNative) | |||
| const { showDeprecationDialog } = useDeprecationDialog() | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
limit the amount of times you display it or some kind of exponential backoff
There was a problem hiding this comment.
added tho following backoff:
- shows first 3 times
- gradually lowers the probability of it showing
- at some point reset.
Good enough?
add: gradually show the modal less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a modal with a notice to UK users.
About # (link your issue here)
#4292
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: