Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug#93 - Coinbase Extension #128

Merged
merged 12 commits into from
Feb 18, 2022
Merged

Bug#93 - Coinbase Extension #128

merged 12 commits into from
Feb 18, 2022

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Jan 21, 2022

Description

Removed general usage of injected connector (only for metamask now)
Fixed metamask not working while coinbase is installed
Added start of coinbase-support but not working yet

About # (link your issue here)

#93

How Has This Been Tested?

Locally on staging / production

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done) -- added temp fix as discussed with sirpy
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

@L03TJ3 L03TJ3 requested a review from sirpy January 21, 2022 18:36
@L03TJ3
Copy link
Collaborator Author

L03TJ3 commented Jan 22, 2022

I have added a possible (draft) solution for supporting both of the extensions separately
( I just realized that there is a little more involved if we want to support CoinBase tho.. )

src/components/NetworkModal/index.tsx Outdated Show resolved Hide resolved
src/components/NetworkModal/index.tsx Outdated Show resolved Hide resolved
@L03TJ3 L03TJ3 requested a review from sirpy January 26, 2022 01:01
Copy link
Contributor

@sirpy sirpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure there are no other places accessing ethereum instead of selectedProvider

src/components/NetworkModal/index.tsx Outdated Show resolved Hide resolved
src/components/NetworkModal/index.tsx Outdated Show resolved Hide resolved
src/components/NetworkModal/index.tsx Outdated Show resolved Hide resolved
src/components/WalletModal/index.tsx Show resolved Hide resolved
src/components/WalletModal/index.tsx Outdated Show resolved Hide resolved
src/hooks/index.ts Outdated Show resolved Hide resolved
src/hooks/index.ts Outdated Show resolved Hide resolved
src/hooks/index.ts Outdated Show resolved Hide resolved
src/hooks/useInactiveListener.ts Show resolved Hide resolved
src/hooks/useInactiveListener.ts Show resolved Hide resolved
@L03TJ3 L03TJ3 requested a review from sirpy February 16, 2022 13:49
src/hooks/useSelectedProvider.ts Outdated Show resolved Hide resolved
src/components/AccountDetails/index.tsx Outdated Show resolved Hide resolved
src/components/NetworkModal/index.tsx Outdated Show resolved Hide resolved
src/components/WalletModal/index.tsx Outdated Show resolved Hide resolved
src/components/WalletModal/index.tsx Outdated Show resolved Hide resolved
src/hooks/index.ts Outdated Show resolved Hide resolved
@L03TJ3 L03TJ3 requested a review from sirpy February 18, 2022 01:30
@L03TJ3 L03TJ3 requested a review from a user February 18, 2022 11:21
@L03TJ3 L03TJ3 merged commit ac0e6d4 into master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants