Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the CrUX History API #20

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add support for the CrUX History API #20

merged 1 commit into from
Jul 31, 2023

Conversation

rviscomi
Copy link
Member

No description provided.

@rviscomi rviscomi requested a review from tunetheweb June 29, 2023 00:09
tunetheweb
tunetheweb approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but where is this file referenced from? Is it only an example JS Script for people? If so might be good to at least reference from the repo README.

@rviscomi
Copy link
Member Author

rviscomi commented Jul 31, 2023 •
edited
Loading

This script is referenced from https://developer.chrome.com/blog/chrome-ux-report-api/. Probably a good idea to reference this from the README, but we don't do that for the other content types in this repo, so leaving that as a bigger TODO in #21.

@rviscomi rviscomi merged commit 6b7f4b0 into main Jul 31, 2023
1 check passed
@rviscomi rviscomi deleted the rviscomi-patch-1 branch July 31, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rviscomi @tunetheweb