-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle "Google Chrome quit unexpectedly" #4
Comments
From @gwuhaolin on June 30, 2017 6:32 I rewrite chrome-launcher with this feature, see chrome-runner. |
From @paulirish on June 30, 2017 17:44 Hi @gwuhaolin! Very sorry for not responding to your issue. I really appreciate you filing a ticket. :) I read your blog post at gwuhaolin/blog#7 and its really interesting. Very cool. I've been looking at chrome-runner and like what you did with it. 👍 I'd love to help incorporate your improvements back into chrome-launcher, if you're interested. I was looking at the source and noticed a few things:
how does all that sound? |
From @gwuhaolin on July 1, 2017 9:57 @paulirish It's a pleasure to be appreciated by you.😊 I have taken your advice remove flags chrome-runner's goal is:
I made a series of chrome related small and reusable tools:
If possible I would be honored to transfer their ownership to the GoogleChrome community, because there are more people in the community who can improve them. chrome-runner(required node7+) has the advantage of comparison with chrome-launcher:
If possible to use chrome-runner to replace chrome-launcher in lighthouse, I would like to submit a merge. |
From @gwuhaolin on June 15, 2017 2:46
Sometime Chrome quit unexpectedly or has no response, chrome-launcher should handle this error and restart a chrome or emit a event to notify developer.
Copied from original issue: GoogleChrome/lighthouse#2503
The text was updated successfully, but these errors were encountered: