Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing component "Blink>ReportingObserver" #565

Closed
jpchase opened this issue Jul 24, 2018 · 2 comments
Closed

Missing component "Blink>ReportingObserver" #565

jpchase opened this issue Jul 24, 2018 · 2 comments
Assignees

Comments

@jpchase
Copy link
Collaborator

jpchase commented Jul 24, 2018

The component "Blink>ReportingObserver" is missing from the list when editing a entry.

As in #496, this component is missing from https://blinkcomponents-b48b5.firebaseapp.com/blinkcomponents, and it's underlying source: https://storage.googleapis.com/chromium-owners/component_map.json.

Upon investigation, I see that component_map.json is populated by scraping OWNERS files in the Chromium code base. See https://cs.chromium.org/chromium/src/tools/checkteamtags/extract_components.py.

This is where we run into a problem for "Blink>ReportingObserver". The OWNERS file only supports one assigned Blink component per directory. The ReportingObserver code lives in a shared directory. We can't reasonably change the existing component mapping. In the longer term, it probably makes sense to move the ReportingObserver to a separate directory.

Regardless, it seems like a problem that the list of available Blink components in chromestatus relies on source code organization in Chromium. I would expect that if the components are defined in crbug.com, then they should be made available for selection when editing an entry.

@aglaforge
Copy link
Collaborator

Do we have any ways to query into Monorail to get a list of components? The indirection seems to be problematic here.

@jpchase
Copy link
Collaborator Author

jpchase commented Aug 20, 2020

Yes, it's possible to use the Monorail API to get a list of components. I've been able to get that working in another project.
@jrobbins I can point you at the internal code (although it's in Go, I think there are Python examples around).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants