Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAG review field value not included in the Intent to Ship email #643

Closed
pwnall opened this issue Apr 30, 2019 · 2 comments
Closed

TAG review field value not included in the Intent to Ship email #643

pwnall opened this issue Apr 30, 2019 · 2 comments

Comments

@pwnall
Copy link

pwnall commented Apr 30, 2019

Example feature: https://www.chromestatus.com/feature/5375472036741120
Generated email: https://groups.google.com/a/chromium.org/d/topic/blink-dev/_-WBHYZ-rBk/discussion

@jpmedley
Copy link
Contributor

@jstenback @RByers I would expect tag review in an intent to implement. Is it supposed to show in the intent to ship. I'd think it would be old news by then.

@pwnall Tag review will not show up on the dashboard card. That information is intended for future users of the feature.

@pwnall
Copy link
Author

pwnall commented Apr 30, 2019

I'm not a Blink API OWNER... but I were, I'd prefer that the Intent to Ship has all the information I need to assess which parts of the relevant process were followed.

jpmedley added a commit that referenced this issue Jun 4, 2019
Fix #643, always include TAG review in intents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants