Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove listener to copy over OT milestone fields #3162

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

DanielRyanSmith
Copy link
Collaborator

Part of the changes to phase out server-side web page rendering and form processing.

This change removes event listeners on the stage edit page to keep track of fields that have been interacted with, as this is already handled separately.
Additionally, the listener to mirror over OT milestone field values into other input fields has been removed, as it is not functional with the new implementation of form submission and tracking "touched" fields. If this functionality would like to be kept, it will need to be implemented in a separate way, but it's likely not needed with the upcoming changes to Origin Trials integration, or can be addressed at that time.

Copy link
Collaborator

@jrobbins jrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's track an issue to reimplement field copying. You might want to leave COPY_ON_EDIT in the code, or put it into the description of that new issue.

@DanielRyanSmith
Copy link
Collaborator Author

@jrobbins I created a new issue and linked this PR, so I can find it for reference later 👍

@DanielRyanSmith DanielRyanSmith merged commit c27f3c6 into main Jul 16, 2023
6 checks passed
@DanielRyanSmith DanielRyanSmith deleted the 2023-07-13_remove-milestone-copying branch July 16, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants