Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Add screen sharing controls blog post + web platform documentation #3869

Merged
merged 6 commits into from
Sep 29, 2022

Conversation

@netlify
Copy link

netlify bot commented Sep 29, 2022

Deploy Preview for developer-chrome-com ready!

Name Link
🔨 Latest commit c8a2567
🔍 Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/6335a00cc35c52000981160d
😎 Deploy Preview https://deploy-preview-3869--developer-chrome-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.


## Reordering the selection offered to the user {: #reordering }

When [`getDisplayMedia()`] is called, users are presented with a media picker which allows them to share whichever display surface they would like any tab, window, or screen. Experience shows that the ordering of the offering affects the users’ selection. We are experimenting in Chrome 107 on desktop with reordering the picker in order to nudge users towards tabs, which is the best option in the majority of cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence becomes ungrammatical towards the end, with a single "like" trying to serve two purposes. (Any surface the users would like; options like...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed offline, I've removed any tab, window, or screen


## Reordering the selection offered to the user {: #reordering }

When [`getDisplayMedia()`] is called, users are presented with a media picker which allows them to share whichever display surface they would like any tab, window, or screen. Experience shows that the ordering of the offering affects the users’ selection. We are experimenting in Chrome 107 on desktop with reordering the picker in order to nudge users towards tabs, which is the best option in the majority of cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"On desktop" might be redundant, as getDisplayMedia is only supported on desktop.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!


### Privacy

Previously, screens were offered as the most prominent option. This is the least privacy-preserving option, as users may end up exposing more personal information than they had originally intended. Such as:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should s/prominent/default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


## What's next {: #future }

[Conditional Focus] will allow the capturing web app to instruct the browser to either switch focus to the captured display surface, or to avoid such a focus change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we mention suppressLocalAudioPlayback as well, do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

```js
const stream = await navigator.mediaDevices.getDisplayMedia({
video: true,
displaySurface: "window", // Pre-select the "Window" pane in the media picker.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max line length exceeded on my device.
https://screenshot.googleplex.com/3PWu7qAeyqaff3W

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@eladalon1983 eladalon1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, would using a numbered list perhaps ensure that people:

  1. ... would be less likely to miss the first bullet, which has no link?
  2. ... would an easier time remembering their position in the doc when jumping back and forth with the other doc?

Whether you accept this suggestion or not, this is now LGTM. :-)

@beaufortfrancois
Copy link
Member Author

Whether you accept this suggestion or not, this is now LGTM. :-)

Fixed.

@rachelandrew
Copy link
Collaborator

@beaufortfrancois your glitch appears to be erroring in the docs.

@rachelandrew
Copy link
Collaborator

Whether you accept this suggestion or not, this is now LGTM. :-)

Fixed.

this should not be a numbered list, as per the style guide. https://developers.google.com/style/lists#types-of-lists please revert this to an unordered list as it is not a sequence of steps.

As a reminder, please make all changes in the Google doc and not on GitHub, and get any LGTMs there. We don't want to have to edit things twice.

@beaufortfrancois
Copy link
Member Author

@beaufortfrancois your glitch appears to be erroring in the docs.

@rachelandrew It "works on my machine". Which error do you see?

image

@rachelandrew
Copy link
Collaborator

It's working now, the first two times I loaded the page I got an error saying there was a problem starting the glitch and the glitch showed the Glitch homepage. It's likely better just to link to it as Glitch is incredibly unreliable, I've been moving a lot of demos to CodePen when it's possible to do so.

@beaufortfrancois
Copy link
Member Author

Whether you accept this suggestion or not, this is now LGTM. :-)

Fixed.

this should not be a numbered list, as per the style guide. https://developers.google.com/style/lists#types-of-lists please revert this to an unordered list as it is not a sequence of steps.

As a reminder, please make all changes in the Google doc and not on GitHub, and get any LGTMs there. We don't want to have to edit things twice.

I've reverted it.

@beaufortfrancois
Copy link
Member Author

It's working now, the first two times I loaded the page I got an error saying there was a problem starting the glitch and the glitch showed the Glitch homepage. It's likely better just to link to it as Glitch is incredibly unreliable, I've been moving a lot of demos to CodePen when it's possible to do so.

Shall we use CodePen from now on? Is there official guidance for that? I wasn't aware of this.

@rachelandrew
Copy link
Collaborator

If CodePen works for the case then it's definitely a better option, it has rarely been unavailable. It isn't possible for every demo, but those where it is I'd suggest using it. We also have a team CodePen account so I can fork demos into that and then we are able to update them.

@beaufortfrancois
Copy link
Member Author

If CodePen works for the case then it's definitely a better option, it has rarely been unavailable. It isn't possible for every demo, but those where it is I'd suggest using it. We also have a team CodePen account so I can fork demos into that and then we are able to update them.

Good to know! Moving forward I'll try to use CodePen then for embedded content on d.c.c. and web.dev then. Thank you!

Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tweaked a heading, otherwise LGTM.

Co-authored-by: Rachel Andrew <rachelandrew@google.com>
@beaufortfrancois beaufortfrancois merged commit 8e1d17d into main Sep 29, 2022
@beaufortfrancois beaufortfrancois deleted the screen-sharing-controls branch September 29, 2022 13:45
@guest271314

This comment was marked as off-topic.

@guest271314

This comment was marked as off-topic.

@guest271314

This comment was marked as off-topic.

@guest271314

This comment was marked as off-topic.

@guest271314

This comment was marked as off-topic.

@beaufortfrancois
Copy link
Member Author

Note, the links at the bottom of the page are 404

displaySurface explainer
surfaceSwitching explainer
selfBrowserSurface explainer
systemAudio explainer

Thank you very much @guest271314!
I've just sent #3953 to address this issue

@eladalon1983 What do you think of the proposed note 4b00c01?

@eladalon1983
Copy link
Contributor

eladalon1983 commented Oct 10, 2022

@eladalon1983 What do you think of the proposed note 4b00c01?

This looks like a clarification specific to getDisplayMedia(), and out of place in articles or blog posts centered around new controls. I'd rather not add it. The key to clear communication is focus.

@guest271314

This comment was marked as off-topic.

@eladalon1983
Copy link
Contributor

Why withhold pertinent information?

Please refer back to the last sentence of my previous message.

@guest271314

This comment was marked as off-topic.

@eladalon1983
Copy link
Contributor

@guest271314,

On the topic of API shape, if you refer to this slide, you'll see that I had proposed a different API shape, which I personally think would have been less confusing. However, working groups requires compromise, and systemAudio is the shape other members of the working group required. You're welcome to take this up with them.

On the topic of speechSynthesis, I see it as out-of-scope for this article. I don't think this is important for a significant enough chunk of this article's readership. That's my opinion.

@guest271314

This comment was marked as off-topic.

@eladalon1983
Copy link
Contributor

@guest271314, I have a family as well as a full time job. Kindly condense your communication into a small number of short messages, or else I am afraid I will not have the time to read them and respond.

@guest271314

This comment was marked as off-topic.

@guest271314

This comment was marked as off-topic.

@rachelandrew
Copy link
Collaborator

I'm going to lock this thread, it seems as if there are a mixture of issues here and some of them seem to be about the spec, this isn't the best venue for that discussion.

If there are specific errors with the content, then they can be raised as a new issue, please raise them as individual issues.

Spec issues should be raised against the spec.

@GoogleChrome GoogleChrome locked as off-topic and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fugu][Media] Video Capture Features
4 participants