-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add screen sharing controls blog post + web platform documentation #3869
Conversation
✅ Deploy Preview for developer-chrome-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
3d7a8c0
to
3a76cfe
Compare
|
||
## Reordering the selection offered to the user {: #reordering } | ||
|
||
When [`getDisplayMedia()`] is called, users are presented with a media picker which allows them to share whichever display surface they would like any tab, window, or screen. Experience shows that the ordering of the offering affects the users’ selection. We are experimenting in Chrome 107 on desktop with reordering the picker in order to nudge users towards tabs, which is the best option in the majority of cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence becomes ungrammatical towards the end, with a single "like" trying to serve two purposes. (Any surface the users would like; options like...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed offline, I've removed any tab, window, or screen
|
||
## Reordering the selection offered to the user {: #reordering } | ||
|
||
When [`getDisplayMedia()`] is called, users are presented with a media picker which allows them to share whichever display surface they would like any tab, window, or screen. Experience shows that the ordering of the offering affects the users’ selection. We are experimenting in Chrome 107 on desktop with reordering the picker in order to nudge users towards tabs, which is the best option in the majority of cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"On desktop" might be redundant, as getDisplayMedia
is only supported on desktop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
|
||
### Privacy | ||
|
||
Previously, screens were offered as the most prominent option. This is the least privacy-preserving option, as users may end up exposing more personal information than they had originally intended. Such as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should s/prominent/default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
## What's next {: #future } | ||
|
||
[Conditional Focus] will allow the capturing web app to instruct the browser to either switch focus to the captured display surface, or to avoid such a focus change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we mention suppressLocalAudioPlayback as well, do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
```js | ||
const stream = await navigator.mediaDevices.getDisplayMedia({ | ||
video: true, | ||
displaySurface: "window", // Pre-select the "Window" pane in the media picker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Max line length exceeded on my device.
https://screenshot.googleplex.com/3PWu7qAeyqaff3W
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, would using a numbered list perhaps ensure that people:
- ... would be less likely to miss the first bullet, which has no link?
- ... would an easier time remembering their position in the doc when jumping back and forth with the other doc?
Whether you accept this suggestion or not, this is now LGTM. :-)
Fixed. |
@beaufortfrancois your glitch appears to be erroring in the docs. |
this should not be a numbered list, as per the style guide. https://developers.google.com/style/lists#types-of-lists please revert this to an unordered list as it is not a sequence of steps. As a reminder, please make all changes in the Google doc and not on GitHub, and get any LGTMs there. We don't want to have to edit things twice. |
@rachelandrew It "works on my machine". Which error do you see? |
It's working now, the first two times I loaded the page I got an error saying there was a problem starting the glitch and the glitch showed the Glitch homepage. It's likely better just to link to it as Glitch is incredibly unreliable, I've been moving a lot of demos to CodePen when it's possible to do so. |
I've reverted it. |
Shall we use CodePen from now on? Is there official guidance for that? I wasn't aware of this. |
If CodePen works for the case then it's definitely a better option, it has rarely been unavailable. It isn't possible for every demo, but those where it is I'd suggest using it. We also have a team CodePen account so I can fork demos into that and then we are able to update them. |
Good to know! Moving forward I'll try to use CodePen then for embedded content on d.c.c. and web.dev then. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tweaked a heading, otherwise LGTM.
Co-authored-by: Rachel Andrew <rachelandrew@google.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Thank you very much @guest271314! @eladalon1983 What do you think of the proposed note 4b00c01? |
This looks like a clarification specific to |
This comment was marked as off-topic.
This comment was marked as off-topic.
Please refer back to the last sentence of my previous message. |
This comment was marked as off-topic.
This comment was marked as off-topic.
On the topic of API shape, if you refer to this slide, you'll see that I had proposed a different API shape, which I personally think would have been less confusing. However, working groups requires compromise, and On the topic of |
This comment was marked as off-topic.
This comment was marked as off-topic.
@guest271314, I have a family as well as a full time job. Kindly condense your communication into a small number of short messages, or else I am afraid I will not have the time to read them and respond. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I'm going to lock this thread, it seems as if there are a mixture of issues here and some of them seem to be about the spec, this isn't the best venue for that discussion. If there are specific errors with the content, then they can be raised as a new issue, please raise them as individual issues. Spec issues should be raised against the spec. |
FIX #3672
Live preview:
cc @eladalon1983