Fix download component behavior when network connection is cut. #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #126
Currently when network connection is lost while a video is being downloaded, the downloader component gets stuck and doesn't either explicitly pause the download or wait for the connection to come back up and resume automatically.
To address this, this PR makes sure that when there is a connection related error encountered by the
DownloadManager
, the current downloads are paused automatically and the UI of the downloader component changes from the "downloading" state to "paused". At the same time a console warning is generated. User can then manually resume the affected downloads once connection is restored.While this is likely not a perfect solution, it may be good enough or may serve as a first step towards a more robust solution. Please let me know your thoughts, @derekherman and / or @beaufortfrancois.
Screencast of the updated behavior
web-dev-download-interrupted-warning.mp4