Update drupal.js #82
Merged
Update drupal.js #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as of Drupal 9.2, webp support is natively supported in Drupal core. Clean-up the docs to make this more clear and not recommend a contrib module.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Co-authored-by: Connor Clark <cjamcl@gmail.com>
raxbg
pushed a commit
to NitroPack/lighthouse-stack-packs
that referenced
this pull request
Jun 28, 2023
as of Drupal 9.2, webp support is natively supported in Drupal core. Clean-up the docs to make this more clear and not recommend a contrib module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of Drupal 9.2, webp support is natively supported in Drupal core. Clean-up the docs to make this more clear and not recommend a contrib module. Version of Drupal 9 prior to 9.2 aren't supported any longer, so streamlined docs seems like the right direction at this point. There is still a bit of an edge case (outlined in https://www.drupal.org/project/drupal/issues/3213491#comment-14473712) why someone might want to still use the contrib module, but that is very time boxed and nuanced reason. Using plain webp is probably enough for most sites.