Skip to content

Commit

Permalink
v10.0.0 (#14594)
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark committed Feb 9, 2023
1 parent 836271a commit 2eb8f34
Show file tree
Hide file tree
Showing 7 changed files with 543 additions and 28 deletions.
533 changes: 531 additions & 2 deletions changelog.md

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"steps": [
{
"lhr": {
"lighthouseVersion": "9.5.0",
"lighthouseVersion": "10.0.0",
"requestedUrl": "https://www.mikescerealshack.co/",
"mainDocumentUrl": "https://www.mikescerealshack.co/",
"finalDisplayedUrl": "https://www.mikescerealshack.co/",
Expand Down Expand Up @@ -7449,7 +7449,7 @@
},
{
"lhr": {
"lighthouseVersion": "9.5.0",
"lighthouseVersion": "10.0.0",
"finalDisplayedUrl": "https://www.mikescerealshack.co/search?q=call+of+duty",
"fetchTime": "2023-01-13T23:27:51.982Z",
"gatherMode": "timespan",
Expand Down Expand Up @@ -11150,7 +11150,7 @@
},
{
"lhr": {
"lighthouseVersion": "9.5.0",
"lighthouseVersion": "10.0.0",
"finalDisplayedUrl": "https://www.mikescerealshack.co/search?q=call+of+duty",
"fetchTime": "2023-01-13T23:28:01.888Z",
"gatherMode": "snapshot",
Expand Down Expand Up @@ -15798,7 +15798,7 @@
},
{
"lhr": {
"lighthouseVersion": "9.5.0",
"lighthouseVersion": "10.0.0",
"requestedUrl": "https://www.mikescerealshack.co/corrections",
"mainDocumentUrl": "https://www.mikescerealshack.co/corrections",
"finalDisplayedUrl": "https://www.mikescerealshack.co/corrections",
Expand Down
2 changes: 1 addition & 1 deletion core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"lighthouseVersion": "9.5.0",
"lighthouseVersion": "10.0.0",
"requestedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html",
"mainDocumentUrl": "http://localhost:10200/dobetterweb/dbw_tester.html",
"finalDisplayedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html",
Expand Down
4 changes: 2 additions & 2 deletions docs/plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ A Lighthouse plugin is just a node module with a name that starts with `lighthou
"name": "lighthouse-plugin-cats",
"main": "plugin.js",
"peerDependencies": {
"lighthouse": "^9.5.0"
"lighthouse": "^10.0.0"
},
"devDependencies": {
"lighthouse": "^9.5.0"
"lighthouse": "^10.0.0"
}
}
```
Expand Down
2 changes: 1 addition & 1 deletion docs/recipes/lighthouse-plugin-example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "module",
"main": "./plugin.js",
"peerDependencies": {
"lighthouse": "^9.5.0"
"lighthouse": "^10.0.0"
},
"devDependencies": {
"lighthouse": "^8.6.0"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "lighthouse",
"type": "module",
"version": "9.5.0",
"version": "10.0.0",
"description": "Automated auditing, performance metrics, and best practices for the web.",
"main": "./core/index.js",
"bin": {
Expand Down
20 changes: 3 additions & 17 deletions third-party/devtools-tests/e2e/lighthouse/navigation_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,7 @@ describe('Navigation', async function() {
assert.strictEqual(numNavigations, 6);
}

// TODO: Reenable this for 10.0
// 9.6.x is forked so Lighthouse ToT is still using 9.5.0 as the version.
// assert.strictEqual(lhr.lighthouseVersion, '9.6.6');
assert.strictEqual(lhr.lighthouseVersion, '10.0.0');
assert.match(lhr.finalUrl, /^https:\/\/localhost:[0-9]+\/test\/e2e\/resources\/lighthouse\/hello.html/);

assert.strictEqual(lhr.configSettings.throttlingMethod, 'simulate');
Expand All @@ -105,13 +103,7 @@ describe('Navigation', async function() {
assert.strictEqual(lhr.configSettings.throttling.rttMs, 150);
assert.strictEqual(lhr.configSettings.screenEmulation.disabled, true);
assert.include(lhr.configSettings.emulatedUserAgent, 'Mobile');

// A bug in FR caused `networkUserAgent` to be excluded from the LHR.
// https://github.com/GoogleChrome/lighthouse/pull/14392
// TODO: Reenable once the fix lands in DT.
if (mode === 'legacy') {
assert.include(lhr.environment.networkUserAgent, 'Mobile');
}
assert.include(lhr.environment.networkUserAgent, 'Mobile');

assert.deepStrictEqual(artifacts.ViewportDimensions, {
innerHeight: 823,
Expand Down Expand Up @@ -257,13 +249,7 @@ describe('Navigation', async function() {
assert.strictEqual(lhr.configSettings.throttling.rttMs, 40);
assert.strictEqual(lhr.configSettings.screenEmulation.disabled, true);
assert.notInclude(lhr.configSettings.emulatedUserAgent, 'Mobile');

// A bug in FR caused `networkUserAgent` to be excluded from the LHR.
// https://github.com/GoogleChrome/lighthouse/pull/14392
// TODO: Reenable once the fix lands in DT.
if (mode === 'legacy') {
assert.notInclude(lhr.environment.networkUserAgent, 'Mobile');
}
assert.notInclude(lhr.environment.networkUserAgent, 'Mobile');

const viewTraceButton = await $textContent('Ver rastro original', reportEl);
assert.ok(viewTraceButton);
Expand Down

0 comments on commit 2eb8f34

Please sign in to comment.