Skip to content

Commit

Permalink
core(lr): disable bf-cache (#14774)
Browse files Browse the repository at this point in the history
  • Loading branch information
adamraine committed Feb 9, 2023
1 parent 106a963 commit 836271a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
8 changes: 6 additions & 2 deletions core/config/lr-desktop-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@ const config = {
throttling: constants.throttling.desktopDense4G,
screenEmulation: constants.screenEmulationMetrics.desktop,
emulatedUserAgent: constants.userAgents.desktop,
// Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
skipAudits: ['uses-http2'],
skipAudits: [
// Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
'uses-http2',
// There are always bf-cache failures when testing in headless. Reenable when headless can give us realistic bf-cache insights.
'bf-cache',
],
},
};

Expand Down
9 changes: 6 additions & 3 deletions core/config/lr-mobile-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,12 @@ const config = {
settings: {
maxWaitForFcp: 15 * 1000,
maxWaitForLoad: 35 * 1000,
// lighthouse:default is mobile by default
// Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
skipAudits: ['uses-http2'],
skipAudits: [
// Skip the h2 audit so it doesn't lie to us. See https://github.com/GoogleChrome/lighthouse/issues/6539
'uses-http2',
// There are always bf-cache failures when testing in headless. Reenable when headless can give us realistic bf-cache insights.
'bf-cache',
],
},
audits: [
'metrics/first-contentful-paint-3g',
Expand Down

0 comments on commit 836271a

Please sign in to comment.