sample json

GoogleChrome · Nov 20, 2018 · aa06403 · aa06403
1 parent 06059c7
commit aa06403
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/lighthouse-core/test/audits/service-worker-test.js b/lighthouse-core/test/audits/service-worker-test.js
@@ -108,6 +108,7 @@ describe('Offline: service worker audit', () => {
     const swOpts = [{
       status: 'activated',
       scriptURL: 'https://example.com/serviceworker/sw.js',
+      // can happen when 'Service-Worker-Allowed' header widens max scope.
       scopeURL: 'https://example.com/',
     }];
 

diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json
@@ -467,13 +467,12 @@
       "score": 0,
       "scoreDisplayMode": "binary",
       "rawValue": false,
-      "explanation": "Failures: No manifest was fetched,\nSite does not register a service worker.",
+      "explanation": "Failures: No manifest was fetched.",
       "details": {
         "items": [
           {
             "failures": [
-              "No manifest was fetched",
-              "Site does not register a service worker"
+              "No manifest was fetched"
             ],
             "isParseFailure": true,
             "parseFailureReason": "No manifest was fetched"

diff --git a/proto/sample_v2_round_trip.json b/proto/sample_v2_round_trip.json
@@ -2548,15 +2548,14 @@
                 "items": [
                     {
                         "failures": [
-                            "No manifest was fetched", 
-                            "Site does not register a service worker"
+                            "No manifest was fetched"
                         ], 
                         "isParseFailure": true, 
                         "parseFailureReason": "No manifest was fetched"
                     }
                 ]
             }, 
-            "explanation": "Failures: No manifest was fetched,\nSite does not register a service worker.", 
+            "explanation": "Failures: No manifest was fetched.", 
             "id": "webapp-install-banner", 
             "score": 0.0, 
             "scoreDisplayMode": "binary",