Update: Use array of non-critical resource types (#2191)

GoogleChrome · May 9, 2017 · bd7f862 · bd7f862
1 parent 0e80b61
commit bd7f862
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/lighthouse-core/gather/computed/critical-request-chains.js b/lighthouse-core/gather/computed/critical-request-chains.js
@@ -33,13 +33,15 @@ class CriticalRequestChains extends ComputedArtifact {
    * @param  {any} request
    */
   isCritical(request) {
-    // XHRs are fetched at High priority, but we exclude them, as they are unlikely to be critical
     const resourceTypeCategory = request._resourceType && request._resourceType._category;
-    if (resourceTypeCategory === WebInspector.resourceTypes.XHR._category) {
-      return false;
-    }
+
+    // XHRs are fetched at High priority, but we exclude them, as they are unlikely to be critical
     // Images are also non-critical.
-    if (resourceTypeCategory === WebInspector.resourceTypes.Image._category) {
+    const nonCriticalResourceTypes = [
+      WebInspector.resourceTypes.Image._category,
+      WebInspector.resourceTypes.XHR._category
+    ];
+    if (nonCriticalResourceTypes.includes(resourceTypeCategory)) {
       return false;
     }