Update: Use array of non-critical resource types #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested changes
May 9, 2017
| @@ -34,12 +34,13 @@ class CriticalRequestChains extends ComputedArtifact { | |||
| */ | |||
| isCritical(request) { | |||
| // XHRs are fetched at High priority, but we exclude them, as they are unlikely to be critical | |||
There was a problem hiding this comment.
the comments relate to the nonCriticalResourceTypes so they shoudl probably be right on top of it.
| WebInspector.resourceTypes.Image._category, | ||
| WebInspector.resourceTypes.XHR._category | ||
| ]; | ||
| if (nonCriticalResourceTypes.includes(resourceTypeCategory)) { |
There was a problem hiding this comment.
the request._resourceType && conflicts with this.
one solution: you can do an early return false if _resourceType is falsy.
There was a problem hiding this comment.
ah nevermind. at worst it'll be [string,string].includes(undefined) which will just fail, but not throw.
no change necessary for this.
|
appreciate the assist on that one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paulirish Follow up PR for #2085
Figured I would add it since I suggested and had time now