autocomplete audit to default config

GoogleChrome · Sep 2, 2020 · e4a56c0 · e4a56c0
1 parent 8862203
commit e4a56c0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/lighthouse-cli/test/smokehouse/test-definitions/forms/form-config.js b/lighthouse-cli/test/smokehouse/test-definitions/forms/form-config.js
@@ -5,14 +5,12 @@
  */
 'use strict';
 
-const experimentalConfig = require('../../../../../lighthouse-core/config/experimental-config.js');
-
 /**
  * @type {LH.Config.Json}
  * Config file for running form gatherer  tests.
  */
 const config = {
-  ...experimentalConfig,
+  extends: 'lighthouse:default',
   settings: {
     onlyAudits: [
       'autocomplete',

diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js
@@ -242,6 +242,7 @@ const defaultConfig = {
     'no-unload-listeners',
     'non-composited-animations',
     'unsized-images',
+    'autocomplete',
     'large-javascript-libraries',
     'valid-source-maps',
     'manual/pwa-cross-browser',
@@ -574,6 +575,7 @@ const defaultConfig = {
         {id: 'deprecations', weight: 1, group: 'best-practices-general'},
         {id: 'errors-in-console', weight: 1, group: 'best-practices-general'},
         {id: 'valid-source-maps', weight: 0, group: 'best-practices-general'},
+        {id: 'autocomplete', weight: 0, group: 'best-practices-ux'},
       ],
     },
     'seo': {

diff --git a/lighthouse-core/config/experimental-config.js b/lighthouse-core/config/experimental-config.js
@@ -14,7 +14,6 @@
 const config = {
   extends: 'lighthouse:default',
   audits: [
-    'autocomplete',
     'full-page-screenshot',
   ],
   passes: [{
@@ -24,13 +23,6 @@ const config = {
     ],
   }],
   categories: {
-    // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default
-    // config is awkward - easier to omit the property here. Will defer to default config.
-    'best-practices': {
-      auditRefs: [
-        {id: 'autocomplete', weight: 0, group: 'best-practices-ux'},
-      ],
-    },
   },
 };