Skip to content

Commit

Permalink
core: adjust audit titles for consistency
Browse files Browse the repository at this point in the history
  • Loading branch information
brendankenny committed Jul 26, 2018
1 parent 6af477a commit e7393b1
Show file tree
Hide file tree
Showing 12 changed files with 36 additions and 28 deletions.
2 changes: 1 addition & 1 deletion lighthouse-core/audits/bootup-time.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const i18n = require('../lib/i18n');

const UIStrings = {
title: 'JavaScript boot-up time',
failureTitle: 'JavaScript boot-up time is too high',
failureTitle: 'Reduce JavaScript boot-up time',
description: 'Consider reducing the time spent parsing, compiling, and executing JS. ' +
'You may find delivering smaller JS payloads helps with this. [Learn ' +
'more](https://developers.google.com/web/tools/lighthouse/audits/bootup).',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const i18n = require('../../lib/i18n');

const UIStrings = {
title: 'Avoids enormous network payloads',
failureTitle: 'Has enormous network payloads',
failureTitle: 'Avoid enormous network payloads',
description:
'Large network payloads cost users real money and are highly correlated with ' +
'long load times. [Learn ' +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const i18n = require('../../lib/i18n');

const UIStrings = {
title: 'Uses efficient cache policy on static assets',
failureTitle: 'Uses inefficient cache policy on static assets',
failureTitle: 'Serve static assets with an efficient cache policy',
description:
'A long cache lifetime can speed up repeat visits to your page. ' +
'[Learn more](https://developers.google.com/web/tools/lighthouse/audits/cache-policy).',
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/critical-request-chains.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const Audit = require('./audit');
const i18n = require('../lib/i18n');

const UIStrings = {
title: 'Critical Request Chains',
title: 'Minimize Critical Request Chains',
description: 'The Critical Request Chains below show you what resources are ' +
'issued with a high priority. Consider reducing ' +
'the length of chains, reducing the download size of resources, or ' +
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/dobetterweb/dom-size.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const MAX_DOM_TREE_DEPTH = 32;

const UIStrings = {
title: 'Avoids an excessive DOM size',
failureTitle: 'Uses an excessive DOM size',
failureTitle: 'Avoid an excessive DOM size',
description: 'Browser engineers recommend pages contain fewer than ' +
`~${MAX_DOM_NODES.toLocaleString()} DOM nodes. The sweet spot is a tree ` +
`depth < ${MAX_DOM_TREE_DEPTH} elements and fewer than ${MAX_DOM_TREE_WIDTH} ` +
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/font-display.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const i18n = require('../lib/i18n');

const UIStrings = {
title: 'All text remains visible during webfont loads',
failureTitle: 'Text is invisible while webfonts are loading',
failureTitle: 'Ensure text remains visible during webfont load',
description: 'Leverage the font-display CSS feature to ensure text is user-visible while ' +
'webfonts are loading. ' +
'[Learn more](https://developers.google.com/web/updates/2016/02/font-display).',
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/audits/mainthread-work-breakdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const i18n = require('../lib/i18n');

const UIStrings = {
title: 'Minimizes main thread work',
failureTitle: 'Has significant main thread work',
failureTitle: 'Minimize main thread work',
description: 'Consider reducing the time spent parsing, compiling and executing JS. ' +
'You may find delivering smaller JS payloads helps with this.',
columnCategory: 'Category',
Expand Down
4 changes: 3 additions & 1 deletion lighthouse-core/audits/time-to-first-byte.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ const Audit = require('./audit');
const i18n = require('../lib/i18n');

const UIStrings = {
title: 'Keep server response times low (TTFB)',
title: 'Server response times are short (TTFB)',
failureTitle: 'Reduce server response times (TTFB)',
description: 'Time To First Byte identifies the time at which your server sends a response.' +
' [Learn more](https://developers.google.com/web/tools/lighthouse/audits/ttfb).',
displayValue: `Root document took {timeInMs, number, milliseconds}\xa0ms`,
Expand All @@ -27,6 +28,7 @@ class TTFBMetric extends Audit {
return {
id: 'time-to-first-byte',
title: str_(UIStrings.title),
failureTitle: str_(UIStrings.failureTitle),
description: str_(UIStrings.description),
requiredArtifacts: ['devtoolsLogs', 'URL'],
};
Expand Down
19 changes: 11 additions & 8 deletions lighthouse-core/lib/locales/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"message": "JavaScript boot-up time"
},
"lighthouse-core/audits/bootup-time.js | failureTitle": {
"message": "JavaScript boot-up time is too high"
"message": "Reduce JavaScript boot-up time"
},
"lighthouse-core/audits/bootup-time.js | description": {
"message": "Consider reducing the time spent parsing, compiling, and executing JS. You may find delivering smaller JS payloads helps with this. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/bootup)."
Expand Down Expand Up @@ -42,7 +42,7 @@
"message": "Avoids enormous network payloads"
},
"lighthouse-core/audits/byte-efficiency/total-byte-weight.js | failureTitle": {
"message": "Has enormous network payloads"
"message": "Avoid enormous network payloads"
},
"lighthouse-core/audits/byte-efficiency/total-byte-weight.js | description": {
"message": "Large network payloads cost users real money and are highly correlated with long load times. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/network-payloads)."
Expand Down Expand Up @@ -78,7 +78,7 @@
"message": "Uses efficient cache policy on static assets"
},
"lighthouse-core/audits/byte-efficiency/uses-long-cache-ttl.js | failureTitle": {
"message": "Uses inefficient cache policy on static assets"
"message": "Serve static assets with an efficient cache policy"
},
"lighthouse-core/audits/byte-efficiency/uses-long-cache-ttl.js | description": {
"message": "A long cache lifetime can speed up repeat visits to your page. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/cache-policy)."
Expand Down Expand Up @@ -111,7 +111,7 @@
"message": "Image formats like JPEG 2000, JPEG XR, and WebP often provide better compression than PNG or JPEG, which means faster downloads and less data consumption. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/webp)."
},
"lighthouse-core/audits/critical-request-chains.js | title": {
"message": "Critical Request Chains"
"message": "Minimize Critical Request Chains"
},
"lighthouse-core/audits/critical-request-chains.js | description": {
"message": "The Critical Request Chains below show you what resources are issued with a high priority. Consider reducing the length of chains, reducing the download size of resources, or deferring the download of unnecessary resources to improve page load. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/critical-request-chains)."
Expand All @@ -123,7 +123,7 @@
"message": "Avoids an excessive DOM size"
},
"lighthouse-core/audits/dobetterweb/dom-size.js | failureTitle": {
"message": "Uses an excessive DOM size"
"message": "Avoid an excessive DOM size"
},
"lighthouse-core/audits/dobetterweb/dom-size.js | description": {
"message": "Browser engineers recommend pages contain fewer than ~1,500 DOM nodes. The sweet spot is a tree depth < 32 elements and fewer than 60 children/parent element. A large DOM can increase memory usage, cause longer [style calculations](https://developers.google.com/web/fundamentals/performance/rendering/reduce-the-scope-and-complexity-of-style-calculations), and produce costly [layout reflows](https://developers.google.com/speed/articles/reflow). [Learn more](https://developers.google.com/web/tools/lighthouse/audits/dom-size)."
Expand All @@ -144,7 +144,7 @@
"message": "All text remains visible during webfont loads"
},
"lighthouse-core/audits/font-display.js | failureTitle": {
"message": "Text is invisible while webfonts are loading"
"message": "Ensure text remains visible during webfont load"
},
"lighthouse-core/audits/font-display.js | description": {
"message": "Leverage the font-display CSS feature to ensure text is user-visible while webfonts are loading. [Learn more](https://developers.google.com/web/updates/2016/02/font-display)."
Expand All @@ -153,7 +153,7 @@
"message": "Minimizes main thread work"
},
"lighthouse-core/audits/mainthread-work-breakdown.js | failureTitle": {
"message": "Has significant main thread work"
"message": "Minimize main thread work"
},
"lighthouse-core/audits/mainthread-work-breakdown.js | description": {
"message": "Consider reducing the time spent parsing, compiling and executing JS. You may find delivering smaller JS payloads helps with this."
Expand Down Expand Up @@ -204,7 +204,10 @@
"message": "Redirects introduce additional delays before the page can be loaded. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/redirects)."
},
"lighthouse-core/audits/time-to-first-byte.js | title": {
"message": "Keep server response times low (TTFB)"
"message": "Server response times are short (TTFB)"
},
"lighthouse-core/audits/time-to-first-byte.js | failureTitle": {
"message": "Reduce server response times (TTFB)"
},
"lighthouse-core/audits/time-to-first-byte.js | description": {
"message": "Time To First Byte identifies the time at which your server sends a response. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/ttfb)."
Expand Down
19 changes: 11 additions & 8 deletions lighthouse-core/lib/locales/en-XA.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"message": "Ĵáv̂áŜćr̂íp̂t́ b̂óôt́-ûṕ t̂ím̂é"
},
"lighthouse-core/audits/bootup-time.js | failureTitle": {
"message": "Ĵáv̂áŜćr̂íp̂t́ b̂óôt́-ûṕ t̂ím̂é îś t̂óô h́îǵĥ"
"message": "R̂éd̂úĉé Ĵáv̂áŜćr̂íp̂t́ b̂óôt́-ûṕ t̂ím̂é"
},
"lighthouse-core/audits/bootup-time.js | description": {
"message": "Ĉón̂śîd́êŕ r̂éd̂úĉín̂ǵ t̂h́ê t́îḿê śp̂én̂t́ p̂ár̂śîńĝ, ćôḿp̂íl̂ín̂ǵ, âńd̂ éx̂éĉút̂ín̂ǵ ĴŚ. Ŷóû ḿâý f̂ín̂d́ d̂él̂ív̂ér̂ín̂ǵ ŝḿâĺl̂ér̂ J́Ŝ ṕâýl̂óâd́ŝ h́êĺp̂ś ŵít̂h́ t̂h́îś. [L̂éâŕn̂ ḿôŕê](h́t̂t́p̂ś://d̂év̂él̂óp̂ér̂ś.ĝóôǵl̂é.ĉóm̂/ẃêb́/t̂óôĺŝ/ĺîǵĥt́ĥóûśê/áûd́ît́ŝ/b́ôót̂úp̂)."
Expand Down Expand Up @@ -42,7 +42,7 @@
"message": "Âv́ôíd̂ś êńôŕm̂óûś n̂ét̂ẃôŕk̂ ṕâýl̂óâd́ŝ"
},
"lighthouse-core/audits/byte-efficiency/total-byte-weight.js | failureTitle": {
"message": "Ĥáŝ én̂ór̂ḿôúŝ ńêt́ŵór̂ḱ p̂áŷĺôád̂ś"
"message": "Âv́ôíd̂ én̂ór̂ḿôúŝ ńêt́ŵór̂ḱ p̂áŷĺôád̂ś"
},
"lighthouse-core/audits/byte-efficiency/total-byte-weight.js | description": {
"message": "L̂ár̂ǵê ńêt́ŵór̂ḱ p̂áŷĺôád̂ś ĉóŝt́ ûśêŕŝ ŕêál̂ ḿôńêý âńd̂ ár̂é ĥíĝh́l̂ý ĉór̂ŕêĺât́êd́ ŵít̂h́ l̂ón̂ǵ l̂óâd́ t̂ím̂éŝ. [Ĺêár̂ń m̂ór̂é](ĥt́t̂ṕŝ://d́êv́êĺôṕêŕŝ.ǵôóĝĺê.ćôḿ/ŵéb̂/t́ôól̂ś/l̂íĝh́t̂h́ôúŝé/âúd̂ít̂ś/n̂ét̂ẃôŕk̂-ṕâýl̂óâd́ŝ)."
Expand Down Expand Up @@ -78,7 +78,7 @@
"message": "Ûśêś êf́f̂íĉíêńt̂ ćâćĥé p̂ól̂íĉý ôń ŝt́ât́îć âśŝét̂ś"
},
"lighthouse-core/audits/byte-efficiency/uses-long-cache-ttl.js | failureTitle": {
"message": "Ûśêś îńêf́f̂íĉíêńt̂ ćâćĥé p̂ól̂íĉý ôń ŝt́ât́îć âśŝét̂ś"
"message": "Ŝér̂v́ê śt̂át̂íĉ áŝśêt́ŝ ẃît́ĥ án̂ éf̂f́îćîén̂t́ ĉáĉh́ê ṕôĺîćŷ"
},
"lighthouse-core/audits/byte-efficiency/uses-long-cache-ttl.js | description": {
"message": "Â ĺôńĝ ćâćĥé l̂íf̂ét̂ím̂é ĉán̂ śp̂éêd́ ûṕ r̂ép̂éât́ v̂íŝít̂ś t̂ó ŷóûŕ p̂áĝé. [L̂éâŕn̂ ḿôŕê](h́t̂t́p̂ś://d̂év̂él̂óp̂ér̂ś.ĝóôǵl̂é.ĉóm̂/ẃêb́/t̂óôĺŝ/ĺîǵĥt́ĥóûśê/áûd́ît́ŝ/ćâćĥé-p̂ól̂íĉý)."
Expand Down Expand Up @@ -111,7 +111,7 @@
"message": "Îḿâǵê f́ôŕm̂át̂ś l̂ík̂é ĴṔÊǴ 2000, ĴṔÊǴ X̂Ŕ, âńd̂ Ẃêb́P̂ óf̂t́êń p̂ŕôv́îd́ê b́êt́t̂ér̂ ćôḿp̂ŕêśŝíôń t̂h́âń P̂ŃĜ ór̂ J́P̂ÉĜ, ẃĥíĉh́ m̂éâńŝ f́âśt̂ér̂ d́ôẃn̂ĺôád̂ś âńd̂ ĺêśŝ d́ât́â ćôńŝúm̂ṕt̂íôń. [L̂éâŕn̂ ḿôŕê](h́t̂t́p̂ś://d̂év̂él̂óp̂ér̂ś.ĝóôǵl̂é.ĉóm̂/ẃêb́/t̂óôĺŝ/ĺîǵĥt́ĥóûśê/áûd́ît́ŝ/ẃêb́p̂)."
},
"lighthouse-core/audits/critical-request-chains.js | title": {
"message": "Ĉŕît́îćâĺ R̂éq̂úêśt̂ Ćĥáîńŝ"
"message": "M̂ín̂ím̂íẑé Ĉŕît́îćâĺ R̂éq̂úêśt̂ Ćĥáîńŝ"
},
"lighthouse-core/audits/critical-request-chains.js | description": {
"message": "T̂h́ê Ćr̂ít̂íĉál̂ Ŕêq́ûéŝt́ Ĉh́âín̂ś b̂él̂óŵ śĥóŵ ýôú ŵh́ât́ r̂éŝóûŕĉéŝ ár̂é îśŝúêd́ ŵít̂h́ â h́îǵĥ ṕr̂íôŕît́ŷ. Ćôńŝíd̂ér̂ ŕêd́ûćîńĝ t́ĥé l̂én̂ǵt̂h́ ôf́ ĉh́âín̂ś, r̂éd̂úĉín̂ǵ t̂h́ê d́ôẃn̂ĺôád̂ śîźê óf̂ ŕêśôúr̂ćêś, ôŕ d̂éf̂ér̂ŕîńĝ t́ĥé d̂óŵńl̂óâd́ ôf́ ûńn̂éĉéŝśâŕŷ ŕêśôúr̂ćêś t̂ó îḿp̂ŕôv́ê ṕâǵê ĺôád̂. [Ĺêár̂ń m̂ór̂é](ĥt́t̂ṕŝ://d́êv́êĺôṕêŕŝ.ǵôóĝĺê.ćôḿ/ŵéb̂/t́ôól̂ś/l̂íĝh́t̂h́ôúŝé/âúd̂ít̂ś/ĉŕît́îćâĺ-r̂éq̂úêśt̂-ćĥáîńŝ)."
Expand All @@ -123,7 +123,7 @@
"message": "Âv́ôíd̂ś âń êx́ĉéŝśîv́ê D́ÔḾ ŝíẑé"
},
"lighthouse-core/audits/dobetterweb/dom-size.js | failureTitle": {
"message": "Ûśêś âń êx́ĉéŝśîv́ê D́ÔḾ ŝíẑé"
"message": "Âv́ôíd̂ án̂ éx̂ćêśŝív̂é D̂ÓM̂ śîźê"
},
"lighthouse-core/audits/dobetterweb/dom-size.js | description": {
"message": "B̂ŕôẃŝér̂ én̂ǵîńêér̂ś r̂éĉóm̂ḿêńd̂ ṕâǵêś ĉón̂t́âín̂ f́êẃêŕ t̂h́âń ~1,500 D̂ÓM̂ ńôd́êś. T̂h́ê śŵéêt́ ŝṕôt́ îś â t́r̂éê d́êṕt̂h́ < 32 êĺêḿêńt̂ś âńd̂ f́êẃêŕ t̂h́âń 60 ĉh́îĺd̂ŕêń/p̂ár̂én̂t́ êĺêḿêńt̂. Á l̂ár̂ǵê D́ÔḾ ĉán̂ ín̂ćr̂éâśê ḿêḿôŕŷ úŝáĝé, ĉáûśê ĺôńĝér̂ [śt̂ýl̂é ĉál̂ćûĺât́îón̂ś](ĥt́t̂ṕŝ://d́êv́êĺôṕêŕŝ.ǵôóĝĺê.ćôḿ/ŵéb̂/f́ûńd̂ám̂én̂t́âĺŝ/ṕêŕf̂ór̂ḿâńĉé/r̂én̂d́êŕîńĝ/ŕêd́ûćê-t́ĥé-ŝćôṕê-án̂d́-ĉóm̂ṕl̂éx̂ít̂ý-ôf́-ŝt́ŷĺê-ćâĺĉúl̂át̂íôńŝ), án̂d́ p̂ŕôd́ûćê ćôśt̂ĺŷ [ĺâýôút̂ ŕêf́l̂óŵś](ĥt́t̂ṕŝ://d́êv́êĺôṕêŕŝ.ǵôóĝĺê.ćôḿ/ŝṕêéd̂/ár̂t́îćl̂éŝ/ŕêf́l̂óŵ). [Ĺêár̂ń m̂ór̂é](ĥt́t̂ṕŝ://d́êv́êĺôṕêŕŝ.ǵôóĝĺê.ćôḿ/ŵéb̂/t́ôól̂ś/l̂íĝh́t̂h́ôúŝé/âúd̂ít̂ś/d̂óm̂-śîźê)."
Expand All @@ -144,7 +144,7 @@
"message": "Âĺl̂ t́êx́t̂ ŕêḿâín̂ś v̂íŝíb̂ĺê d́ûŕîńĝ ẃêb́f̂ón̂t́ l̂óâd́ŝ"
},
"lighthouse-core/audits/font-display.js | failureTitle": {
"message": "T̂éx̂t́ îś îńv̂íŝíb̂ĺê ẃĥíl̂é ŵéb̂f́ôńt̂ś âŕê ĺôád̂ín̂ǵ"
"message": "Êńŝúr̂é t̂éx̂t́ r̂ém̂áîńŝ v́îśîb́l̂é d̂úr̂ín̂ǵ ŵéb̂f́ôńt̂ ĺôád̂"
},
"lighthouse-core/audits/font-display.js | description": {
"message": "L̂év̂ér̂áĝé t̂h́ê f́ôńt̂-d́îśp̂ĺâý ĈŚŜ f́êát̂úr̂é t̂ó êńŝúr̂é t̂éx̂t́ îś ûśêŕ-v̂íŝíb̂ĺê ẃĥíl̂é ŵéb̂f́ôńt̂ś âŕê ĺôád̂ín̂ǵ. [L̂éâŕn̂ ḿôŕê](h́t̂t́p̂ś://d̂év̂él̂óp̂ér̂ś.ĝóôǵl̂é.ĉóm̂/ẃêb́/ûṕd̂át̂éŝ/2016/02/f́ôńt̂-d́îśp̂ĺâý)."
Expand All @@ -153,7 +153,7 @@
"message": "M̂ín̂ím̂íẑéŝ ḿâín̂ t́ĥŕêád̂ ẃôŕk̂"
},
"lighthouse-core/audits/mainthread-work-breakdown.js | failureTitle": {
"message": "Ĥáŝ śîǵn̂íf̂íĉán̂t́ m̂áîń t̂h́r̂éâd́ ŵór̂ḱ"
"message": "M̂ín̂ím̂íẑé m̂áîń t̂h́r̂éâd́ ŵór̂ḱ"
},
"lighthouse-core/audits/mainthread-work-breakdown.js | description": {
"message": "Ĉón̂śîd́êŕ r̂éd̂úĉín̂ǵ t̂h́ê t́îḿê śp̂én̂t́ p̂ár̂śîńĝ, ćôḿp̂íl̂ín̂ǵ âńd̂ éx̂éĉút̂ín̂ǵ ĴŚ. Ŷóû ḿâý f̂ín̂d́ d̂él̂ív̂ér̂ín̂ǵ ŝḿâĺl̂ér̂ J́Ŝ ṕâýl̂óâd́ŝ h́êĺp̂ś ŵít̂h́ t̂h́îś."
Expand Down Expand Up @@ -204,7 +204,10 @@
"message": "R̂éd̂ír̂éĉt́ŝ ín̂t́r̂ód̂úĉé âd́d̂ít̂íôńâĺ d̂él̂áŷś b̂éf̂ór̂é t̂h́ê ṕâǵê ćâń b̂é l̂óâd́êd́. [L̂éâŕn̂ ḿôŕê](h́t̂t́p̂ś://d̂év̂él̂óp̂ér̂ś.ĝóôǵl̂é.ĉóm̂/ẃêb́/t̂óôĺŝ/ĺîǵĥt́ĥóûśê/áûd́ît́ŝ/ŕêd́îŕêćt̂ś)."
},
"lighthouse-core/audits/time-to-first-byte.js | title": {
"message": "K̂éêṕ ŝér̂v́êŕ r̂éŝṕôńŝé t̂ím̂éŝ ĺôẃ (T̂T́F̂B́)"
"message": "Ŝér̂v́êŕ r̂éŝṕôńŝé t̂ím̂éŝ ár̂é ŝh́ôŕt̂ (T́T̂F́B̂)"
},
"lighthouse-core/audits/time-to-first-byte.js | failureTitle": {
"message": "R̂éd̂úĉé ŝér̂v́êŕ r̂éŝṕôńŝé t̂ím̂éŝ (T́T̂F́B̂)"
},
"lighthouse-core/audits/time-to-first-byte.js | description": {
"message": "T̂ím̂é T̂ó F̂ír̂śt̂ B́ŷt́ê íd̂én̂t́îf́îéŝ t́ĥé t̂ím̂é ât́ ŵh́îćĥ ýôúr̂ śêŕv̂ér̂ śêńd̂ś â ŕêśp̂ón̂śê. [Ĺêár̂ń m̂ór̂é](ĥt́t̂ṕŝ://d́êv́êĺôṕêŕŝ.ǵôóĝĺê.ćôḿ/ŵéb̂/t́ôól̂ś/l̂íĝh́t̂h́ôúŝé/âúd̂ít̂ś/t̂t́f̂b́)."
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/scripts/assert-golden-lhr-unchanged.sh
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@ if [ $retVal -eq 0 ]; then
colorText "✅ PASS. No change in LHR." "$green"
else
colorText "❌ FAIL. LHR has changed." "$red"
echo "Run \`yarn update:sample-json\` to rebaseline the golden LHR."
echo "Run \`yarn i18n:collect-strings\` and \`yarn update:sample-json\` to rebaseline the golden LHR."
fi
exit $retVal
Loading

0 comments on commit e7393b1

Please sign in to comment.