Update BlockedByResponse string; Make capitalization consistent

GoogleChrome · Nov 2, 2020 · ed284f9 · ed284f9
1 parent 63c1bdd
commit ed284f9
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/lighthouse-core/audits/dobetterweb/has-inspector-issues.js b/lighthouse-core/audits/dobetterweb/has-inspector-issues.js
@@ -29,8 +29,8 @@ const UIStrings = {
   /* eslint-enable max-len */
   /** Table column header for the types of problems observed in a website, like security or network errors. */
   columnIssueType: 'Issue type',
-  /** The type of an Issue in Chrome DevTools when a resource is blocked due to receiving a rejection in the response to a request made on the page. */
-  issueTypeBlockedByResponse: 'Blocked by response',
+  /** The type of an Issue in Chrome DevTools when a resource is blocked due to the website's cross-origin policy. */
+  issueTypeBlockedByResponse: 'Blocked by cross-origin policy',
   /** The type of an Issue in Chrome DevTools when a site has large ads that use up a lot of the browser's resources. */
   issueTypeHeavyAds: 'Heavy resource usage by ads',
 };
@@ -62,7 +62,7 @@ class IssuesPanelEntries extends Audit {
       requestUrls.add(requestUrl);
     }
     return {
-      issueType: 'Mixed Content',
+      issueType: 'Mixed content',
       subItems: {
         type: 'subitems',
         items: Array.from(requestUrls).map(url => ({url})),
@@ -83,7 +83,7 @@ class IssuesPanelEntries extends Audit {
       }
     }
     return {
-      issueType: 'SameSite Cookie',
+      issueType: 'SameSite cookie',
       subItems: {
         type: 'subitems',
         items: Array.from(requestUrls).map(url => {
@@ -133,7 +133,7 @@ class IssuesPanelEntries extends Audit {
       }
     }
     return {
-      issueType: 'Content Security Policy',
+      issueType: 'Content security policy',
       subItems: {
         type: 'subitems',
         items: Array.from(requestUrls).map(url => {

diff --git a/lighthouse-core/lib/i18n/locales/en-US.json b/lighthouse-core/lib/i18n/locales/en-US.json
diff --git a/lighthouse-core/lib/i18n/locales/en-XL.json b/lighthouse-core/lib/i18n/locales/en-XL.json
diff --git a/lighthouse-core/test/audits/dobetterweb/has-inspector-issues-test.js b/lighthouse-core/test/audits/dobetterweb/has-inspector-issues-test.js
@@ -54,7 +54,7 @@ describe('Has inspector issues audit', () => {
     });
     expect(auditResult.score).toBe(0);
     expect(auditResult.details.items[0]).toMatchObject({
-      issueType: 'Mixed Content',
+      issueType: 'Mixed content',
       subItems: {
         type: 'subitems',
         items: [
@@ -89,7 +89,7 @@ describe('Has inspector issues audit', () => {
     });
     expect(auditResult.score).toBe(0);
     expect(auditResult.details.items[0]).toMatchObject({
-      issueType: 'SameSite Cookie',
+      issueType: 'SameSite cookie',
       subItems: {
         type: 'subitems',
         items: [
@@ -146,7 +146,7 @@ describe('Has inspector issues audit', () => {
     expect(auditResult.score).toBe(0);
     expect(auditResult.details.items[0]).toMatchObject({
       issueType: {
-        formattedDefault: 'Blocked By Response',
+        formattedDefault: 'Blocked by cross-origin policy',
       },
       subItems: {
         type: 'subitems',
@@ -192,7 +192,7 @@ describe('Has inspector issues audit', () => {
     expect(auditResult.score).toBe(0);
     expect(auditResult.details.items[0]).toMatchObject({
       issueType: {
-        formattedDefault: 'Heavy Ads',
+        formattedDefault: 'Heavy resource usage by ads',
       },
     });
   });
@@ -228,7 +228,7 @@ describe('Has inspector issues audit', () => {
     });
     expect(auditResult.score).toBe(0);
     expect(auditResult.details.items[0]).toMatchObject({
-      issueType: 'Content Security Policy',
+      issueType: 'Content security policy',
       subItems: {
         type: 'subitems',
         items: [