core(cache-headers): fix typo in must-revalidate (#7189)

GoogleChrome · Feb 8, 2019 · f4b9d10 · f4b9d10
1 parent 5c0483c
commit f4b9d10
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lighthouse-core/audits/byte-efficiency/uses-long-cache-ttl.js b/lighthouse-core/audits/byte-efficiency/uses-long-cache-ttl.js
@@ -175,7 +175,7 @@ class CacheHeaders extends Audit {
     // Ignore assets where policy implies they should not be cached long periods
     if (cacheControl &&
       (
-        cacheControl['must-validate'] ||
+        cacheControl['must-revalidate'] ||
         cacheControl['no-cache'] ||
         cacheControl['no-store'] ||
         cacheControl['private'])) {

diff --git a/lighthouse-core/test/audits/byte-efficiency/uses-long-cache-ttl-test.js b/lighthouse-core/test/audits/byte-efficiency/uses-long-cache-ttl-test.js
@@ -190,7 +190,7 @@ describe('Cache headers audit', () => {
 
   it('ignores assets where policy implies they should not be cached long periods', () => {
     const networkRecords = [
-      networkRecord({headers: {'cache-control': 'must-validate'}}),
+      networkRecord({headers: {'cache-control': 'must-revalidate'}}),
       networkRecord({headers: {'cache-control': 'no-cache'}}),
       networkRecord({headers: {'cache-control': 'private'}}),
     ];

diff --git a/types/parse-cache-control/index.d.ts b/types/parse-cache-control/index.d.ts
@@ -8,7 +8,7 @@ declare module 'parse-cache-control' {
   // Follows the potential settings of cache-control, see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control
   interface CacheHeaders {
     'max-age'?: number;
-    'must-validate'?: boolean;
+    'must-revalidate'?: boolean;
     'no-cache'?: boolean;
     'no-store'?: boolean;
     'private'?: boolean;