deps(axe-core): upgrade to 4.1.2 (#12075)

GoogleChrome · Feb 11, 2021 · f9f799c · f9f799c
1 parent d10a464
commit f9f799c
Show file tree

Hide file tree

Showing 7 changed files with 257 additions and 298 deletions.
diff --git a/lighthouse-core/gather/gatherers/accessibility.js b/lighthouse-core/gather/gatherers/accessibility.js
@@ -22,6 +22,14 @@ async function runA11yChecks() {
   /** @type {import('axe-core/axe')} */
   // @ts-expect-error axe defined by axeLibSource
   const axe = window.axe;
+  const application = `lighthouse-${Math.random()}`;
+  axe.configure({
+    branding: {
+      application,
+    },
+    // @ts-expect-error axe types don't yet include this new field
+    noHtml: true,
+  });
   const axeResults = await axe.run(document, {
     elementRef: true,
     runOnly: {
@@ -59,11 +67,14 @@ async function runA11yChecks() {
 
   /** @param {import('axe-core/axe').Result} result */
   const augmentAxeNodes = result => {
+    result.helpUrl = result.helpUrl.replace(application, 'lighthouse');
+    if (axeResults.inapplicable.includes(result)) return;
+
     result.nodes.forEach(node => {
       // @ts-expect-error - getNodeDetails put into scope via stringification
       node.node = getNodeDetails(node.element);
       // @ts-expect-error - avoid circular JSON concerns
-      node.element = node.any = node.all = node.none = undefined;
+      node.element = node.any = node.all = node.none = node.html = undefined;
     });
 
     // Ensure errors can be serialized over the protocol
@@ -85,6 +96,7 @@ async function runA11yChecks() {
   // Augment the node objects with outerHTML snippet & custom path string
   axeResults.violations.forEach(augmentAxeNodes);
   axeResults.incomplete.forEach(augmentAxeNodes);
+  axeResults.inapplicable.forEach(augmentAxeNodes);
 
   // We only need violations, and circular references are possible outside of violations
   return {

diff --git a/lighthouse-core/test/report/html/renderer/category-renderer-test.js b/lighthouse-core/test/report/html/renderer/category-renderer-test.js
@@ -340,7 +340,7 @@ describe('CategoryRenderer', () => {
       const categoryClone = JSON.parse(JSON.stringify(category));
 
       // Remove groups from some audits.
-      const ungroupedAudits = ['color-contrast', 'image-alt', 'link-name'];
+      const ungroupedAudits = ['image-alt', 'link-name'];
       for (const auditRef of categoryClone.auditRefs) {
         if (ungroupedAudits.includes(auditRef.id)) {
           assert.ok(auditRef.group); // Make sure this will change something.

diff --git a/lighthouse-core/test/results/artifacts/artifacts.json b/lighthouse-core/test/results/artifacts/artifacts.json
diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json
diff --git a/package.json b/package.json
@@ -157,7 +157,7 @@
     "webtreemap-cdt": "^3.0.1"
   },
   "dependencies": {
-    "axe-core": "4.1.1",
+    "axe-core": "4.1.2",
     "chrome-launcher": "^0.13.4",
     "configstore": "^5.0.1",
     "cssstyle": "1.2.1",

diff --git a/types/artifacts.d.ts b/types/artifacts.d.ts
@@ -166,7 +166,6 @@ declare global {
         impact?: string;
         tags: Array<string>;
         nodes: Array<{
-          html: string;
           target: Array<string>;
           failureSummary?: string;
           node: NodeDetails;

diff --git a/yarn.lock b/yarn.lock
@@ -1182,10 +1182,10 @@ aws4@^1.8.0:
   resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.8.0.tgz#f0e003d9ca9e7f59c7a508945d7b2ef9a04a542f"
   integrity sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ==
 
-axe-core@4.1.1:
-  version "4.1.1"
-  resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.1.1.tgz#70a7855888e287f7add66002211a423937063eaf"
-  integrity sha512-5Kgy8Cz6LPC9DJcNb3yjAXTu3XihQgEdnIg50c//zOC/MyLP0Clg+Y8Sh9ZjjnvBrDZU4DgXS9C3T9r4/scGZQ==
+axe-core@4.1.2:
+  version "4.1.2"
+  resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.1.2.tgz#7cf783331320098bfbef620df3b3c770147bc224"
+  integrity sha512-V+Nq70NxKhYt89ArVcaNL9FDryB3vQOd+BFXZIfO3RP6rwtj+2yqqqdHEkacutglPaZLkJeuXKCjCJDMGPtPqg==
 
 babel-code-frame@^6.22.0:
   version "6.26.0"