-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace inquirer with enquirer #12305
Comments
Following is the proof-of-concept changes. Though a few devDependencies still depends on inquirer, my motivation is speeding up CI setup which runs lighthouse so that not installing inquirer by executing |
history can be found: https://github.com/GoogleChrome/lighthouse/issues?q=inquirer+is%3Aclosed #642 (comment) heh :P @takenspc would you like to send a PR? nice RE: the lack of types for |
See also this comment on getting matching behavior in enquirer, but that was more than two years ago so maybe easier to fix now :) |
It would be great to update this since we just updated to 4.0.1 and it looks like most of the changes are dropping |
|
oh nice, thanks for sharing the update! |
The path was suggest at GoogleChrome#12305 (comment)
The path was suggest at GoogleChrome#12305 (comment)
both of these were updated. Thanks again @takenspc! |
The package install size of lighthouse weighs 65.6MB.
https://packagephobia.com/result?p=lighthouse
This seems big. Though some packages are unavoidable, some packages can be replaced with smaller one.
The inquirer is one of big packages as it depends on rxjs. Replacing inquirer with enquirer would reduce the install size.
Pros:
Cons:
Note: upgrading jsonld to 5 will reduce the install size too.
The text was updated successfully, but these errors were encountered: