Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update jsonld to latest #12338

Merged
merged 3 commits into from
Apr 9, 2021
Merged

deps: update jsonld to latest #12338

merged 3 commits into from
Apr 9, 2021

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented Apr 7, 2021

thanks to @davidlehn's work with jsonld@5, this drops a number of our shipped npm dependencies, most importantly request. That's about 4 MiB savings in node_modules when a project uses Lighthouse, and two fewer warnings on yarn add lighthouse (which were for the deprecated request and request > har-validator).

Thanks also to @takenspc for pointing out the available jsonld savings in #12305.

Also a drive-by removal of coveralls which we still included as a devDep. request remains a devDep for us due to our two dev versions of jsdom, but that's on their radar (but it's difficult): jsdom/jsdom#2792

also ref: #8328 #12324

@brendankenny brendankenny requested a review from a team as a code owner April 7, 2021 23:50
@brendankenny brendankenny requested review from paulirish and removed request for a team April 7, 2021 23:50
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants