Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report: empty details table row when showing URLs #4818

Closed
kdzwinel opened this issue Mar 20, 2018 · 0 comments
Closed

Report: empty details table row when showing URLs #4818

kdzwinel opened this issue Mar 20, 2018 · 0 comments

Comments

@kdzwinel
Copy link
Collaborator

kdzwinel commented Mar 20, 2018 •
edited
Loading

screen shot 2018-03-20 at 02 09 26

It looks like bc9efba#diff-99cea3b0b135c7e5a46c068661e7cf5eR96 updated only type: 'text' entries to use value instead of text, but type: 'url' should also be updated.

Replacing text with value here:

lighthouse/lighthouse-core/audits/seo/is-crawlable.js

Line 110 in adf4f86

text: robotsFileUrl.href,

fixes the is-crawlable audit, but potentially more audits are affected.

[EDIT] It looks like #4616 was created before is-crawlable was merged, so that's probably why is-crawlable wasn't updated to use value and it's probably only affected audit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdzwinel