core(i18n): add strings for user timing entries table #5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Aug 8, 2018
| @@ -27,7 +27,7 @@ const UIStrings = { | |||
| columnScriptParse: 'Script Parse', | |||
| /** A message displayed in a Lighthouse audit result warning that Chrome extensions on the user's system substantially affected Lighthouse's measurements and instructs the user on how to run again without those extensions. */ | |||
| chromeExtensionsWarning: 'Chrome extensions negatively affected this page\'s load' + | |||
| ' performance. Try auditing the page in incognito mode or from a clean Chrome profile.', | |||
| ' performance. Try auditing the page in incognito mode or from a profile without extensions.', | |||
There was a problem hiding this comment.
bikeshed: "from a Chrome profile without extensions"?
| {key: 'timingType', itemType: 'text', text: 'Type'}, | ||
| {key: 'startTime', itemType: 'ms', granularity: 0.01, text: 'Start Time'}, | ||
| {key: 'duration', itemType: 'ms', granularity: 0.01, text: 'Duration'}, | ||
| {key: 'name', itemType: 'text', text: UIStrings.columnName}, |
There was a problem hiding this comment.
str_(UIStrings.whatever) for all of these
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also a driveby fix for b/112186129