clients(viewer): update manifest icons #10002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
do we really need that many?
I doubt it's the same as extensions but any chance we can just use svg https://twitter.com/mathias/status/1196816651834068994 :D
|
there's a weird transition in canary from manifest icon to favicon icon (see that email I sent yesterday). idk why, maybe bug. but in case it isn't I figured the smaller images will here should be the same as the favicon image, so there is no transition. on the other hand ..... we could just delete this manifest. |
|
oh ya I got all of that, updating icon is fine. I'm just wondering why we have so many sizes all the way up to 1000px, are all of those actually used and relevant to this bug? |
|
hahaha idk why i added that big one ooops |
patrickhulce
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.