tests: use assert in strict assertion mode #10606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Apr 18, 2020
| @@ -38,7 +38,7 @@ describe('DOM', () => { | |||
| const el = dom.createElement('div'); | |||
| assert.equal(el.localName, 'div'); | |||
| assert.equal(el.className, ''); | |||
| assert.equal(el.className, el.attributes.length); | |||
There was a problem hiding this comment.
no idea what this was trying to test, so I did my best :)
There was a problem hiding this comment.
lol this is hilarious
connorjclark
approved these changes
Apr 21, 2020
| @@ -414,8 +414,8 @@ describe('DetailsRenderer', () => { | |||
| assert.equal(anchorEl.href, 'https://www.example.com/script.js'); | |||
| assert.equal(sourceLocationEl.textContent, '/script.js:11:5(www.example.com)'); | |||
| assert.equal(sourceLocationEl.getAttribute('data-source-url'), sourceLocation.url); | |||
| assert.equal(sourceLocationEl.getAttribute('data-source-line'), sourceLocation.line); | |||
| assert.equal(sourceLocationEl.getAttribute('data-source-column'), sourceLocation.column); | |||
| assert.equal(sourceLocationEl.getAttribute('data-source-line'), `${sourceLocation.line}`); | |||
There was a problem hiding this comment.
nit: you like this better than String()? was the line limit reached if you did that?
There was a problem hiding this comment.
nit: you like this better than String()? was the line limit reached if you did that?
it does go over the limit on the column lines, but I also don't have a particular preference between the two
| @@ -38,7 +38,7 @@ describe('DOM', () => { | |||
| const el = dom.createElement('div'); | |||
| assert.equal(el.localName, 'div'); | |||
| assert.equal(el.className, ''); | |||
| assert.equal(el.className, el.attributes.length); | |||
There was a problem hiding this comment.
lol this is hilarious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict assertion mode has been recommended since it was added in Node v9.9.0, and treats all the equality asserts as strict equality assertions. It also gives nicer deep equality diffs.
Not much was caught here, which is good news. A few
null->undefinedandnumber->stringcoercions, and a couple of old audit scores that weren't updated when all scores went numeric.