report: fix zebra styling, sub item rows for 3p filter #10978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should get something into the sample JSON vercel deployment that has subitems. should we add experimental audits to our sample JSON generation? |
patrickhulce
suggested changes
Jun 17, 2020
| @@ -191,7 +191,8 @@ describe('ReportUIFeatures', () => { | |||
|
|
|||
| function getUrlsInTable() { | |||
There was a problem hiding this comment.
can we get a test for the subitem filtering in sync with their parent row? :)
| const shouldHideThirdParty = e.target instanceof HTMLInputElement && !e.target.checked; | ||
| let even = true; | ||
| let rowEl = rowEls[0]; | ||
| while (rowEl) { |
There was a problem hiding this comment.
this took a minute for me to parse with the double nested while, I don't have stellar suggestions though. I think making the innermost loop as simple as possible works for me :)
There was a problem hiding this comment.
gMakunde
pushed a commit
to gMakunde/lighthouse
that referenced
this pull request
Jul 6, 2020
gMakunde
pushed a commit
to gMakunde/lighthouse
that referenced
this pull request
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10867 broke the 3p filter in two significant ways: zebra styling didn't take into account the CSS class approach we now have, and sub item rows weren't filtered w/ their 3p parent row.