misc: remove all appveyor references #11171
Conversation
|
cmd+f AppVeyor build status badge, some env vars. |
|
if we're ready to completely purge? :D aye aye 🖖 |
patrickhulce
changed the title
|
oh it's so beautiful 😍 |
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| # Download chrome inside of our CI env. | |||
|
|
|||
| if [ "$APPVEYOR" == "True" ]; then | |||
There was a problem hiding this comment.
lol that wasn't a great check for any windows users
| @@ -1,4 +1,4 @@ | |||
| # Lighthouse [](https://travis-ci.org/GoogleChrome/lighthouse) [](https://ci.appveyor.com/project/paulirish/lighthouse/branch/master) [](https://coveralls.io/github/GoogleChrome/lighthouse?branch=master) [](https://npmjs.org/package/lighthouse) | |||
| # Lighthouse [](https://github.com/GoogleChrome/lighthouse/actions) [](https://travis-ci.org/GoogleChrome/lighthouse) [](https://coveralls.io/github/GoogleChrome/lighthouse?branch=master) [](https://npmjs.org/package/lighthouse) | |||
There was a problem hiding this comment.
(https://github.com/GoogleChrome/lighthouse/workflows/💡🏠/badge.svg)](https://github.com/GoogleChrome/lighthouse/actions)
Yay, but this is where we start to regret our workflow name. They still haven't fixed handling of emoji in their badge generator 😢
I guess we can pretend that little bit of the lightbulb peeking out isn't there and it's just a nameless badge until they fix things :)
There was a problem hiding this comment.
I guess we can pretend that little bit of the lightbulb peeking out isn't there and it's just a nameless badge until they fix things
LOL I didn't even notice the peeking lighthouse I just thought "huh that's weird they don't give it a name" 😆
was definitely surprised that our emoji in the URL just worked out of the box
|
anyone else want to be a part of the approval magic? @connorjclark @paulirish you did a lot of the lifting here care to do the honors :) |
Summary
Standing on the shoulders of giants (#11087 ,#10620, #11009), this PR removes our AppVeyor configuration to eliminate the last red check mark in our status checks :D 🎉
RIP AppVeyor 💀
#11087 well covers us at this point for Windows and since the rate-limiting fiasco was resolved it has been very fast with minimal queuing.