core(axe): use our html snippet rather than axe's #11362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Sep 1, 2020
paulirish
commented
Sep 1, 2020
| @@ -89,7 +89,7 @@ const expectations = [ | |||
| node: { | |||
| 'type': 'node', | |||
| 'selector': '#aria-required-children', | |||
| 'snippet': '<div id="aria-required-children" role="radiogroup">\n <div></div>\n </div>', | |||
| @@ -53,7 +53,7 @@ const expectations = [ | |||
| 'height': '>0', | |||
| }, | |||
| 'selector': '#aria-hidden-focus', | |||
| 'snippet': '<div id="aria-hidden-focus" aria-hidden="true">\n <button>Focusable Button</button>\n </div>', | |||
| 'snippet': '<div id="aria-hidden-focus" aria-hidden="true">', | |||
There was a problem hiding this comment.
at first blush we're losing 'Focusable Button' but we actually have that in nodeLabel. so we good.
same with a few other of these cases.
connorjclark
reviewed
Sep 1, 2020
| @@ -363,7 +363,7 @@ const expectations = [ | |||
| 'type': 'node', | |||
| 'selector': 'h3', | |||
| 'path': '2,HTML,1,BODY,37,SECTION,1,H3', | |||
| 'snippet': '<h3>sub-sub-header</h3>', | |||
There was a problem hiding this comment.
dont like this loss. should we change our snippet?
There was a problem hiding this comment.
nodeLabel has it covered.
paulirish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found while working with @gMakunde on his audit. the autofilltypepredictions that are in the DOM were picked up by axe as the
node.html.. it's just a basic outerHTML grab: https://github.com/dequelabs/axe-core/blob/0cd1eade459a5e3b36220ab9a4d3884db678cc99/lib/core/utils/dq-element.js#L16-L22since our getOuterHTMLSnippet() is far more sophisticated these days.. we should prefer that.