tests: hash more files for devtools test cache #11417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny
and removed request for
a team
|
Oh, I do expect this to fail now because of #11414 (comment) |
.github/workflows/devtools.yml
Outdated
| ${{ env.DEVTOOLS_PATH }} | ||
| ${{ env.BLINK_TOOLS_PATH }} | ||
| ${{ github.workspace }}/lighthouse/.tmp/chromium-web-tests/content-shells | ||
| key: ${{ runner.os }}-${{ hashFiles('lighthouse/.github/workflows/devtools.yml', 'lighthouse/dist/lighthouse-dt-bundle.js', 'lighthouse/lighthouse-core/test/chromium-web-tests/download-*') }} |
There was a problem hiding this comment.
lighthouse/dist/lighthouse-dt-bundle.js
won't this mean it won't use the cache on basically any change to core?
There was a problem hiding this comment.
shoot, good point. I will use the build bundle, devtools entry, and devtools reports files instead.
10 tasks
|
Current CI failure is that is cuz it wants #11418 landed
|
|
i guess the retry_3 line in run-web-tests.sh is being a jerk
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes like #11411 . GitHub actions cache will keep stuff around for a week, so we need a way to invalidate it when the devtools bundle changes.